@not-depracted is not taken into account

[mibocs]

I got the following error in my Drupal:

Call to deprecated method loadRevision() of interface Drupal\Core\Entity\RevisionableStorageInterface:
in drupal:10.1.0 and is removed from drupal:11.0.0. Use
\Drupal\Core\Entity\RevisionableStorageInterface::loadRevision instead.

This should be solved in theory if i apply the following fix: https://www.drupal.org/project/drupal/issues/3571148 i.e. if i use

/** @not-deprecated */

then this error shouldn't be reported(this should work according to phpstan => https://phpstan.org/writing-php-code/phpdocs-basics#deprecations), but it is reported because this is not taken into account in phpstan-deprecation-rules.

My phpstan.neon config file is the following:

includes:

• vendor/mglaman/phpstan-drupal/extension.neon
• vendor/mglaman/phpstan-drupal/rules.neon
• vendor/phpstan/phpstan-deprecation-rules/rules.neon
  parameters:
  level: '1'
  paths:
  • lib
    excludePaths:
  • vendor
  • lib/themes/dta_theme/node_modules/*
    ignoreErrors:
  • '#^Unsafe usage of new static#'
    drupal:
    drupal_root: '%currentWorkingDirectory%/web'
    parallel:
    processTimeout: 900.0

If i remove "vendor/phpstan/phpstan-deprecation-rules/rules.neon" line then this error is gone, so the issue is in the phpstan-deprecation-rules for sure.

Question is how could this be solved?

[VincentLanglet]

Works fine to me with @not-deprecated

See https://phpstan.org/r/1d609f28-6228-41f7-9c4b-bbfa78dbf6d4
vs
https://phpstan.org/r/4ba2fce3-1e1a-4911-98df-d577f642f0b2

[mibocs]

Thanks @VincentLanglet for the quick reply.

Could you tell me the version of your phpstan and phpstan-deprecation-rules? Thanks

[VincentLanglet]

The playground always uses the latest versions.

The issue is reported as tested and solved here
https://www.drupal.org/project/drupal/issues/3571148#comment-16453474

So I assume the issue is on your side for not using the right version/fork of drupal.
But it's not a phpstan issue.

This should be solved in theory if i apply the following fix: drupal.org/project/drupal/issues/3571148

I dunno how you applied this fix, but if you modify your vendor manually you'll need to clear the phpstan cache and anyway, it won't pass on your CI.

[mibocs]

So I assume the issue is on your side for not using the right version/fork of Drupal.

Yea it seems.

I dunno how you applied this fix

I just manually added that one line to the RevisionableStorageInterface::loadRevision(), and nothing changed. Should i have done something else after this like clearing the cache of phpstan? I don't think so.

but if you modify your vendor manually

Why would i modify anything there? I never do this.

Either way i will investigate the issue on my side. Thanks

[mibocs]

@VincentLanglet

I managed to find the issue: mglaman/phpstan-drupal#939

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.