-
Notifications
You must be signed in to change notification settings - Fork 119
Expand file tree
/
Copy pathQueryBuilderDqlRule.php
More file actions
132 lines (111 loc) · 3.4 KB
/
Copy pathQueryBuilderDqlRule.php
File metadata and controls
132 lines (111 loc) · 3.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
<?php declare(strict_types = 1);
namespace PHPStan\Rules\Doctrine\ORM;
use AssertionError;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\Query\QueryException;
use PhpParser\Node;
use PhpParser\Node\Expr\MethodCall;
use PHPStan\Analyser\Scope;
use PHPStan\Rules\Rule;
use PHPStan\Rules\RuleErrorBuilder;
use PHPStan\Type\Doctrine\DoctrineTypeUtils;
use PHPStan\Type\Doctrine\ObjectMetadataResolver;
use PHPStan\Type\ObjectType;
use Throwable;
use function array_values;
use function count;
use function sprintf;
use function strpos;
/**
* @implements Rule<Node\Expr\MethodCall>
*/
class QueryBuilderDqlRule implements Rule
{
private ObjectMetadataResolver $objectMetadataResolver;
private bool $reportDynamicQueryBuilders;
public function __construct(
ObjectMetadataResolver $objectMetadataResolver,
bool $reportDynamicQueryBuilders
)
{
$this->objectMetadataResolver = $objectMetadataResolver;
$this->reportDynamicQueryBuilders = $reportDynamicQueryBuilders;
}
public function getNodeType(): string
{
return Node\Expr\MethodCall::class;
}
public function processNode(Node $node, Scope $scope): array
{
if (!$node->name instanceof Node\Identifier) {
return [];
}
if ($node->name->toLowerString() !== 'getquery') {
return [];
}
$calledOnType = $scope->getType($node->var);
$queryBuilderTypes = DoctrineTypeUtils::getQueryBuilderTypes($calledOnType);
if (count($queryBuilderTypes) === 0) {
if (
$this->reportDynamicQueryBuilders
&& (new ObjectType('Doctrine\ORM\QueryBuilder'))->isSuperTypeOf($calledOnType)->yes()
) {
return [
RuleErrorBuilder::message('Could not analyse QueryBuilder with unknown beginning.')
->identifier('doctrine.queryBuilderDynamic')
->build(),
];
}
return [];
}
try {
$dqlType = $scope->getType(new MethodCall($node, new Node\Identifier('getDQL'), []));
} catch (Throwable $e) {
return [
RuleErrorBuilder::message(sprintf('Internal error: %s', $e->getMessage()))
->nonIgnorable()
->identifier('doctrine.internalError')
->build(),
];
}
$dqls = $dqlType->getConstantStrings();
if (count($dqls) === 0) {
if ($this->reportDynamicQueryBuilders) {
return [
RuleErrorBuilder::message('Could not analyse QueryBuilder with dynamic arguments.')
->identifier('doctrine.queryBuilderDynamicArgument')
->build(),
];
}
return [];
}
$entityManagerInterface = 'Doctrine\ORM\EntityManagerInterface';
$messages = [];
foreach ($dqls as $dql) {
$objectManager = $this->objectMetadataResolver->getObjectManagerForDql($dql->getValue());
if (!$objectManager instanceof $entityManagerInterface) {
continue;
}
/** @var EntityManagerInterface $objectManager */
$objectManager = $objectManager;
try {
$objectManager->createQuery($dql->getValue())->getAST();
} catch (QueryException $e) {
$message = sprintf('QueryBuilder: %s', $e->getMessage());
if (strpos($e->getMessage(), '[Syntax Error]') === 0) {
$message .= sprintf("\nDQL: %s", $dql->getValue());
}
$builder = RuleErrorBuilder::message($message)
->identifier('doctrine.dql');
if (count($dqls) > 1) {
$builder->addTip('Detected from DQL branch: ' . $dql->getValue());
}
// Use message as index to prevent duplicate
$messages[$message] = $builder->build();
} catch (AssertionError $e) {
continue;
}
}
return array_values($messages);
}
}