Update test for phpstan 2.2 (#759)

Author: VincentLanglet

tests/Platform/QueryResultTypeWalkerFetchTypeMatrixTest.php

@@ -52,10 +52,12 @@
 use PHPUnit\Framework\Constraint\IsIdentical;
 use Psr\Log\LoggerInterface;
 use Throwable;
+use function assert;
 use function class_exists;
 use function floor;
 use function getenv;
 use function in_array;
+use function is_string;
 use function method_exists;
 use function reset;
 use function sprintf;
@@ -65,6 +67,9 @@
 /**
  * This test ensures our query type inferring never differs from actual result types produced by PHP, Database drivers and Doctrine (with various versions and configurations).
  *
+ * @phpstan-type Driver 'ibm_db2'|'mysqli'|'oci8'|'pdo_mysql'|'pdo_oci'|'pdo_pgsql'|'pdo_sqlite'|'pdo_sqlsrv'|'pgsql'|'sqlite3'|'sqlsrv'
+ * @phpstan-import-type Params from DriverManager
+ *
  * @group platform
  */
 final class QueryResultTypeWalkerFetchTypeMatrixTest extends PHPStanTestCase
@@ -4433,6 +4438,7 @@ public static function provideCases(): iterable
 	}
 
 	/**
+	 * @param Driver $driver
 	 * @param mixed $expectedFirstResult
 	 * @param array<string, mixed> $data
 	 * @param self::STRINGIFY_* $stringification
@@ -4512,7 +4518,7 @@ private function performDriverTest(
 	}
 
 	/**
-	 * @param array<string, mixed> $connectionParams
+	 * @param Params $connectionParams
 	 */
 	private function createConnection(
 		array $connectionParams
@@ -4535,7 +4541,7 @@ private function createConnection(
 			$connection->executeQuery('USE foo');
 		}
 
-		if ($connectionParams['driver'] === 'pdo_mysql') {
+		if (isset($connectionParams['driver']) && $connectionParams['driver'] === 'pdo_mysql') {
 			$connection->executeQuery('SET GLOBAL max_connections = 1000');
 		}
 
@@ -4735,23 +4741,29 @@ private function assertInferredResultMatchesExpected(
 	}
 
 	/**
-	 * @return array<string, mixed>
+	 * @return Params
 	 */
 	private function getConnectionParamsForDriver(string $driver): array
 	{
 		switch ($driver) {
 			case 'pdo_mysql':
 			case 'mysqli':
+				$host = getenv('MYSQL_HOST');
+				assert(is_string($host));
+
 				return [
-					'host' => getenv('MYSQL_HOST'),
+					'host' => $host,
 					'user' => 'root',
 					'password' => 'secret',
 					'dbname' => 'foo',
 				];
 			case 'pdo_pgsql':
 			case 'pgsql':
+				$host = getenv('PGSQL_HOST');
+				assert(is_string($host));
+
 				return [
-					'host' => getenv('PGSQL_HOST'),
+					'host' => $host,
 					'user' => 'root',
 					'password' => 'secret',
 					'dbname' => 'foo',
@@ -4764,8 +4776,11 @@ private function getConnectionParamsForDriver(string $driver): array
 				];
 			case 'pdo_sqlsrv':
 			case 'sqlsrv':
+				$host = getenv('MSSQL_HOST');
+				assert(is_string($host));
+
 				return [
-					'host' => getenv('MSSQL_HOST'),
+					'host' => $host,
 					'user' => 'SA',
 					'password' => 'Secret.123',
 					// user database is created after connection

tests/Type/Doctrine/Query/QueryResultTypeWalkerHydrationModeTest.php

@@ -114,7 +114,7 @@ public function test(Type $expectedType, string $dql, string $methodName, ?int $
 	}
 
 	/**
-	 * @return iterable<string,array{Type,string,2?:string|null}>
+	 * @return iterable<string,array{Type,string,string,3?:int|null}>
 	 */
 	public static function getTestData(): iterable
 	{