fix: handle first-class callable crash on Expr methods

When first-class callable syntax ($expr->in(...)) is used inside match
arms or assigned to variables, PHPStan resolves the closure and visits
the extension with a MethodCall where isFirstClassCallable() is false
and getArgs() is empty. This causes the actual Expr method to be called
with 0 arguments, crashing with ArgumentCountError.

Fix with two guards:
- isFirstClassCallable() for direct first-class callable syntax
- try/catch ArgumentCountError around the reflective method invocation
  for indirect cases (match arms, variable assignments)

Closes #711

Co-Authored-By: Simon Podlipsky <simon@podlipsky.net>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: simPod

src/Type/Doctrine/QueryBuilder/Expr/BaseExpressionDynamicReturnTypeExtension.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Type\Doctrine\QueryBuilder\Expr;
 
+use ArgumentCountError;
 use PhpParser\Node\Expr\MethodCall;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\MethodReflection;
@@ -38,6 +39,10 @@ public function isMethodSupported(MethodReflection $methodReflection): bool
 
 	public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): ?Type
 	{
+		if ($methodCall->isFirstClassCallable()) {
+			return null;
+		}
+
 		try {
 			$args = $this->argumentsProcessor->processArgs($scope, $methodReflection->getName(), $methodCall->getArgs());
 		} catch (DynamicQueryBuilderArgumentException $e) {
@@ -55,7 +60,12 @@ public function getTypeFromMethodCall(MethodReflection $methodReflection, Method
 			return null;
 		}
 
-		$exprValue = $expr->{$methodReflection->getName()}(...$args);
+		try {
+			$exprValue = $expr->{$methodReflection->getName()}(...$args);
+		} catch (ArgumentCountError) {
+			return null;
+		}
+
 		if (is_object($exprValue)) {
 			return new ExprType(get_class($exprValue), $exprValue);
 		}

src/Type/Doctrine/QueryBuilder/Expr/ExpressionBuilderDynamicReturnTypeExtension.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Type\Doctrine\QueryBuilder\Expr;
 
+use ArgumentCountError;
 use Doctrine\ORM\EntityManagerInterface;
 use PhpParser\Node\Expr\MethodCall;
 use PHPStan\Analyser\Scope;
@@ -43,6 +44,10 @@ public function isMethodSupported(MethodReflection $methodReflection): bool
 
 	public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): ?Type
 	{
+		if ($methodCall->isFirstClassCallable()) {
+			return null;
+		}
+
 		$objectManager = $this->objectMetadataResolver->getObjectManager();
 		if ($objectManager === null) {
 			return null;
@@ -74,7 +79,12 @@ public function getTypeFromMethodCall(MethodReflection $methodReflection, Method
 			return null;
 		}
 
-		$exprValue = $expr->{$methodReflection->getName()}(...$args);
+		try {
+			$exprValue = $expr->{$methodReflection->getName()}(...$args);
+		} catch (ArgumentCountError) {
+			return null;
+		}
+
 		if (is_object($exprValue)) {
 			return new ExprType(get_class($exprValue), $exprValue);
 		}

tests/Rules/Doctrine/ORM/QueryBuilderDqlFirstClassCallableTest.php

@@ -0,0 +1,36 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Doctrine\ORM;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use PHPStan\Type\Doctrine\ObjectMetadataResolver;
+
+/**
+ * @extends RuleTestCase<QueryBuilderDqlRule>
+ */
+class QueryBuilderDqlFirstClassCallableTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new QueryBuilderDqlRule(
+			new ObjectMetadataResolver(__DIR__ . '/entity-manager.php', __DIR__ . '/../../../../tmp'),
+			true,
+		);
+	}
+
+	public function testFirstClassCallableInMatchArm(): void
+	{
+		$this->analyse([__DIR__ . '/data/query-builder-first-class-callable.php'], []);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [
+			__DIR__ . '/../../../../extension.neon',
+			__DIR__ . '/entity-manager.neon',
+		];
+	}
+
+}

tests/Rules/Doctrine/ORM/data/query-builder-first-class-callable.php

@@ -0,0 +1,47 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Doctrine\ORM;
+
+use Doctrine\ORM\EntityManager;
+
+class TestFirstClassCallableExpr
+{
+
+	/** @var EntityManager */
+	private $entityManager;
+
+	public function __construct(EntityManager $entityManager)
+	{
+		$this->entityManager = $entityManager;
+	}
+
+	public function matchArmWithFirstClassCallable(): void
+	{
+		$queryBuilder = $this->entityManager->createQueryBuilder();
+		$expr = $queryBuilder->expr();
+
+		$comparator = match (random_int(0, 1)) {
+			0 => $expr->in(...),
+			1 => $expr->notIn(...),
+		};
+
+		$queryBuilder->select('e')
+			->from(MyEntity::class, 'e')
+			->andWhere($comparator('e.id', [1, 2, 3]));
+		$queryBuilder->getQuery();
+	}
+
+	public function variableWithFirstClassCallable(): void
+	{
+		$queryBuilder = $this->entityManager->createQueryBuilder();
+		$expr = $queryBuilder->expr();
+
+		$fn = $expr->eq(...);
+
+		$queryBuilder->select('e')
+			->from(MyEntity::class, 'e')
+			->andWhere($fn('e.id', '1'));
+		$queryBuilder->getQuery();
+	}
+
+}