Fields are not checked in orderBy in findBy/findOneBy functions

[whataboutpereira]

While checking fields in the criteria of findBy and findOneBy functions works nicely, I notice mistyped field names in orderBy are being ignored.

$this->findBy([], ['dates' => 'desc']); will happily pass when the actual field is date.

Would it be hard to add field checking for orderBy in those repository functions?

Thanks!

[VincentLanglet]

It's not that hard to add this I think ; do you want to do the PR @whataboutpereira ?

The rule is here

phpstan-doctrine/src/Rules/Doctrine/ORM/RepositoryMethodCallRule.php

Line 69 in 6fe9e9d

foreach ($argType->getConstantArrays() as $constantArray) {

You can see that argType is the first param

phpstan-doctrine/src/Rules/Doctrine/ORM/RepositoryMethodCallRule.php

Line 39 in 6fe9e9d

$argType = $scope->getType($node->getArgs()[0]->value);

You'll need to do the same for the second param for methods with an order param

[whataboutpereira]

Hello and thanks for the pointers! I'll definitely have a look at it.

[whataboutpereira]

That worked. Unfortunately it fails to catch faulty passed on arguments like thus.

    public function findAll(array $orderBy = ['name' => 'ASC']): array
    {
        return $this->findBy([], $orderBy);
    }