Cleanup EntityRepositoryClassReflectionExtension#740
Merged
staabm merged 1 commit intophpstan:2.0.xfrom Apr 14, 2026
Merged
Conversation
staabm
commented
Apr 14, 2026
| strpos($methodName, 'findOneBy') === 0 | ||
| ) { | ||
| $returnType = TypeCombinator::union($entityClassType, new NullType()); | ||
| $returnType = TypeCombinator::addNull($entityClassType); |
Comment on lines
-91
to
-94
| $repositoryAncesor = $classReflection->getAncestorWithClassName(ObjectRepository::class); | ||
| if ($repositoryAncesor === null) { | ||
| throw new ShouldNotHappenException(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
in the past this code was used to support ObjectRepository classes from different namespaces (across different major versions of doctrine), see a497a38#diff-3cbc418c0bd3c05155f1b1f786e9a6c12efe64d7599b402dbd19299942061b74R47-R53
the remaining code references the very same class which is a leftover of this feature which no longer exists
VincentLanglet
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
looking into this right now, because we see CI errors related to this lines of code in phpstan/phpstan-src#5449