Failing test - args trimming logic needs some work

Author: ondrejmirtes

tests/Rules/PHPUnit/DataProviderDataRuleTest.php

@@ -190,6 +190,44 @@ public function testRule(): void
 		]);
 	}
 
+	public function testVariadicMethod(): void
+	{
+		$this->analyse([__DIR__ . '/data/data-provider-variadic-method.php'], [
+			[
+				'Method DataProviderVariadicMethod\FooTest::testProvide2() invoked with 1 parameter, at least 2 required.',
+				12,
+			],
+			[
+				'Parameter #1 $a of method DataProviderVariadicMethod\FooTest::testProvide() expects int, string given.',
+				13,
+			],
+			[
+				'Method DataProviderVariadicMethod\FooTest::testProvide2() invoked with 1 parameter, at least 2 required.',
+				13,
+			],
+			[
+				'Parameter #1 $a of method DataProviderVariadicMethod\FooTest::testProvide2() expects int, string given.',
+				13,
+			],
+			[
+				'Parameter #2 ...$rest of method DataProviderVariadicMethod\FooTest::testProvide() expects string, int given.',
+				15,
+			],
+			[
+				'Parameter #3 ...$rest of method DataProviderVariadicMethod\FooTest::testProvide() expects string, int given.',
+				15,
+			],
+			[
+				'Parameter #2 $two of method DataProviderVariadicMethod\FooTest::testProvide2() expects string, int given.',
+				15,
+			],
+			[
+				'Parameter #3 ...$rest of method DataProviderVariadicMethod\FooTest::testProvide2() expects string, int given.',
+				15,
+			],
+		]);
+	}
+
 	/**
 	 * @return string[]
 	 */

tests/Rules/PHPUnit/data/data-provider-variadic-method.php

@@ -0,0 +1,61 @@
+<?php
+
+namespace DataProviderVariadicMethod;
+
+use PHPUnit\Framework\TestCase;
+
+class FooTest extends TestCase
+{
+
+	public function dataProvide(): iterable
+	{
+		yield [1];
+		yield ['foo'];
+		yield [1, 'foo', 'bar'];
+		yield [1, 2, 3];
+	}
+
+	/**
+	 * @dataProvider dataProvide
+	 */
+	public function testProvide(int $a, string ...$rest): void
+	{
+
+	}
+
+	/**
+	 * @dataProvider dataProvide
+	 */
+	public function testProvide2(int $a, string $two, string ...$rest): void
+	{
+
+	}
+
+}
+
+class BarTest extends TestCase
+{
+
+	public function dataProvide(): iterable
+	{
+		yield [1, 2];
+		yield [3, 4];
+	}
+
+	/**
+	 * @dataProvider dataProvide
+	 */
+	public function testProvide(int $i): void
+	{
+
+	}
+
+	/**
+	 * @dataProvider dataProvide
+	 */
+	public function testProvide2(int ...$args): void
+	{
+
+	}
+
+}