support named args

Author: staabm

src/Rules/PHPUnit/DataProviderDataRule.php

@@ -142,9 +142,27 @@ private function arrayItemsToArgs(ConstantArrayType $array): ?array
 	{
 		$args = [];
 
-		foreach ($array->getValueTypes() as $valueType) {
-			// XXX named args
-			$arg = new Node\Arg(new TypeExpr($valueType));
+		$keyTypes = $array->getKeyTypes();
+		foreach ($array->getValueTypes() as $i => $valueType) {
+			$key = $keyTypes[$i]->getConstantStrings();
+			if (count($key) > 1) {
+				return null;
+			}
+
+			if (count($key) === 0) {
+				$arg = new Node\Arg(new TypeExpr($valueType));
+				$args[] = $arg;
+				continue;
+
+			}
+
+			$arg = new Node\Arg(
+				new TypeExpr($valueType),
+				false,
+				false,
+				[],
+				new Node\Identifier($key[0]->getValue()),
+			);
 			$args[] = $arg;
 		}
 

tests/Rules/PHPUnit/DataProviderDataRuleTest.php

@@ -99,9 +99,17 @@ public function testRule(): void
 				172,
 			],
 			[
-				'Parameter #2 $input of method DataProviderDataTest\UnionTypeReturnTest::testWithAnnotation() expects string, int given.',
+				'Parameter #2 $input of method DataProviderDataTest\UnionTypeReturnTest::testFoo() expects string, int given.',
 				216,
 			],
+			[
+				'Parameter $input of method DataProviderDataTest\NamedArgsInProvider::testFoo() expects string, int given.',
+				255,
+			],
+			[
+				'Parameter $input of method DataProviderDataTest\NamedArgsInProvider::testFoo() expects string, false given.',
+				255,
+			],
 		]);
 	}
 

tests/Rules/PHPUnit/data/data-provider-data.php

@@ -191,7 +191,7 @@ class UnionTypeReturnTest extends TestCase
 {
 
 	/** @dataProvider aProvider */
-	public function testWithAnnotation(string $expectedResult, string $input): void
+	public function testFoo(string $expectedResult, string $input): void
 	{
 	}
 
@@ -216,3 +216,42 @@ public function aProvider(): array
 		return $arr;
 	}
 }
+
+
+class NamedArgsInProvider extends TestCase
+{
+
+	/** @dataProvider aProvider */
+	public function testFoo(string $expectedResult, string $input): void
+	{
+	}
+
+	public function aProvider(): array
+	{
+		$arr = [
+			[
+				"input" => 'Hello World',
+				"expectedResult" => " Hello World \n"
+			]
+		];
+
+		if (rand(0,1)) {
+			$arr = [
+				[
+					"input" => 123,
+					"expectedResult" => " Hello World \n"
+				]
+			];
+		}
+		if (rand(0,1)) {
+			$arr = [
+				[
+					"input" => false,
+					"expectedResult" => " Hello World \n"
+				]
+			];
+		}
+
+		return $arr;
+	}
+}