factor out buildArrayTypesFromNode()

Author: staabm

src/Rules/PHPUnit/DataProviderDataRule.php

@@ -47,34 +47,15 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		$arraysTypes = [];
-		if ($node instanceof Node\Stmt\Return_ || $node instanceof Node\Expr\YieldFrom) {
-			if ($node->expr === null) {
-				return [];
-			}
-
-			$exprType = $scope->getType($node->expr);
-			$exprConstArrays = $exprType->getConstantArrays();
-			foreach ($exprConstArrays as $constArray) {
-				foreach ($constArray->getValueTypes() as $valueType) {
-					foreach ($valueType->getConstantArrays() as $constValueArray) {
-						$arraysTypes[] = $constValueArray;
-					}
-				}
-			}
-
-			if ($arraysTypes === []) {
-				$arraysTypes = $exprType->getIterableValueType()->getArrays();
-			}
-		} elseif ($node instanceof Node\Expr\Yield_) {
-			if ($node->value === null) {
-				return [];
-			}
-
-			$exprType = $scope->getType($node->value);
-			$arraysTypes = $exprType->getConstantArrays();
+		if (
+			!$node instanceof Node\Stmt\Return_
+			&& !$node instanceof Node\Expr\Yield_
+			&& !$node instanceof Node\Expr\YieldFrom
+		) {
+			return [];
 		}
 
+		$arraysTypes = $this->buildArrayTypesFromNode($node, $scope);
 		if ($arraysTypes === []) {
 			return [];
 		}
@@ -182,4 +163,41 @@ private function arrayItemsToArgs(Type $array, int $numberOfParameters): ?array
 		return $args;
 	}
 
+	/**
+	 * @param Node\Stmt\Return_|Node\Expr\Yield_|Node\Expr\YieldFrom $node
+	 * @return array<Type>
+	 */
+	private function buildArrayTypesFromNode(Node $node, Scope $scope): array
+	{
+		$arraysTypes = [];
+		if ($node instanceof Node\Stmt\Return_ || $node instanceof Node\Expr\YieldFrom) {
+			if ($node->expr === null) {
+				return [];
+			}
+
+			$exprType = $scope->getType($node->expr);
+			$exprConstArrays = $exprType->getConstantArrays();
+			foreach ($exprConstArrays as $constArray) {
+				foreach ($constArray->getValueTypes() as $valueType) {
+					foreach ($valueType->getConstantArrays() as $constValueArray) {
+						$arraysTypes[] = $constValueArray;
+					}
+				}
+			}
+
+			if ($arraysTypes === []) {
+				$arraysTypes = $exprType->getIterableValueType()->getArrays();
+			}
+		} elseif ($node instanceof Node\Expr\Yield_) {
+			if ($node->value === null) {
+				return [];
+			}
+
+			$exprType = $scope->getType($node->value);
+			$arraysTypes = $exprType->getConstantArrays();
+		}
+
+		return $arraysTypes;
+	}
+
 }