Attempt to fix hard-to-reproduce bug

Author: ondrejmirtes

src/Analyser/MutatingScope.php

@@ -3909,6 +3909,18 @@ public function mergeWith(?self $otherScope): self
 			$mergedExpressionTypes,
 		);
 
+		$filter = static function (ExpressionTypeHolder $expressionTypeHolder) {
+			if ($expressionTypeHolder->getCertainty()->yes()) {
+				return true;
+			}
+
+			$expr = $expressionTypeHolder->getExpr();
+
+			return $expr instanceof Variable || $expr instanceof VirtualNode;
+		};
+
+		$mergedExpressionTypes = array_filter($mergedExpressionTypes, $filter);
+
 		$ourNativeExpressionTypes = $this->nativeExpressionTypes;
 		$theirNativeExpressionTypes = $otherScope->nativeExpressionTypes;
 		$mergedNativeExpressionTypes = [];
@@ -3942,7 +3954,7 @@ public function mergeWith(?self $otherScope): self
 			$this->getFunction(),
 			$this->getNamespace(),
 			$mergedExpressionTypes,
-			array_merge($mergedNativeExpressionTypes, $this->mergeVariableHolders($ourNativeExpressionTypes, $theirNativeExpressionTypes)),
+			array_merge($mergedNativeExpressionTypes, array_filter($this->mergeVariableHolders($ourNativeExpressionTypes, $theirNativeExpressionTypes), $filter)),
 			$conditionalExpressions,
 			$this->inClosureBindScopeClasses,
 			$this->anonymousFunctionReflection,
@@ -4078,11 +4090,6 @@ private function mergeVariableHolders(array $ourVariableTypeHolders, array $thei
 				$intersectedVariableTypeHolders[$exprString] = $variableTypeHolder->and($theirVariableTypeHolders[$exprString]);
 			} else {
 				$expr = $variableTypeHolder->getExpr();
-
-				if (!$expr instanceof Variable && !$expr instanceof VirtualNode) {
-					continue;
-				}
-
 				if (!$expr->hasAttribute(self::CONTAINS_SUPER_GLOBAL_ATTRIBUTE_NAME)) {
 					$expr->setAttribute(self::CONTAINS_SUPER_GLOBAL_ATTRIBUTE_NAME, $nodeFinder->findFirst($expr, $globalVariableCallback) !== null);
 				}
@@ -4100,11 +4107,6 @@ private function mergeVariableHolders(array $ourVariableTypeHolders, array $thei
 			}
 
 			$expr = $variableTypeHolder->getExpr();
-
-			if (!$expr instanceof Variable && !$expr instanceof VirtualNode) {
-				continue;
-			}
-
 			if (!$expr->hasAttribute(self::CONTAINS_SUPER_GLOBAL_ATTRIBUTE_NAME)) {
 				$expr->setAttribute(self::CONTAINS_SUPER_GLOBAL_ATTRIBUTE_NAME, $nodeFinder->findFirst($expr, $globalVariableCallback) !== null);
 			}