Regression test

Author: ondrejmirtes

tests/.claude/settings.local.json

@@ -0,0 +1,7 @@
+{
+  "permissions": {
+    "allow": [
+      "WebFetch(domain:phpbench.readthedocs.io)"
+    ]
+  }
+}

tests/PHPStan/Rules/Comparison/IfConstantConditionRuleTest.php

@@ -201,4 +201,16 @@ public function testBug7699(): void
 		$this->analyse([__DIR__ . '/data/bug-7699.php'], []);
 	}
 
+	public function testBug4284(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-4284.php'], [
+			[
+				'If condition is always true.',
+				25,
+				'Because the type is coming from a PHPDoc, you can turn off this check by setting <fg=cyan>treatPhpDocTypesAsCertain: false</> in your <fg=cyan>%configurationFile%</>.',
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-4284.php

@@ -0,0 +1,30 @@
+<?php declare(strict_types = 1);
+
+namespace Bug4284;
+
+class HelloWorld
+{
+	/** @param mixed[] $browser */
+	public function sayHello(array $browser): void
+	{
+		$browserName = '';
+		$upgradeBrowserLink = '';
+
+		if ($browser['name'] === 1) {
+			$browserName = '123';
+			$upgradeBrowserLink = '456';
+		} elseif ($browser['name'] === 2) {
+			$browserName = '789';
+			$upgradeBrowserLink = '123';
+		}
+
+		if ($browserName && $upgradeBrowserLink) {
+			//
+		}
+		if ($browserName) {
+			if ($upgradeBrowserLink) {
+				//
+			}
+		}
+	}
+}