Revert "Fix phpstan/phpstan#14319: PHPStan takes extremely long analyzing if-offset checks on array|object (#5242)"

This reverts commit 7e07096.

Author: ondrejmirtes

src/Analyser/MutatingScope.php

@@ -139,8 +139,6 @@ class MutatingScope implements Scope, NodeCallbackInvoker
 	public const KEEP_VOID_ATTRIBUTE_NAME = 'keepVoid';
 	private const CONTAINS_SUPER_GLOBAL_ATTRIBUTE_NAME = 'containsSuperGlobal';
 
-	private const ARRAY_DIM_FETCH_UNION_HAS_OFFSET_VALUE_TYPE_LIMIT = 16;
-
 	/** @var Type[] */
 	private array $resolvedTypes = [];
 
@@ -2732,39 +2730,16 @@ public function specifyExpressionType(Expr $expr, Type $type, Type $nativeType,
 				$exprVarType = $scope->getType($expr->var);
 				$isArray = $exprVarType->isArray();
 				if (!$exprVarType instanceof MixedType && !$isArray->no()) {
-					$tooManyHasOffsetValueTypes = false;
-
 					$varType = $exprVarType;
 					if (!$isArray->yes()) {
 						if ($dimType->isInteger()->yes()) {
 							$varType = TypeCombinator::intersect($exprVarType, StaticTypeFactory::intOffsetAccessibleType());
 						} else {
 							$varType = TypeCombinator::intersect($exprVarType, StaticTypeFactory::generalOffsetAccessibleType());
 						}
-
-						if ($exprVarType instanceof UnionType) {
-							$hasOffsetAccessoryCount = 0;
-							foreach ($exprVarType->getTypes() as $innerType) {
-								foreach (TypeUtils::getAccessoryTypes($innerType) as $accessoryType) {
-									if (!($accessoryType instanceof HasOffsetValueType)) {
-										continue;
-									}
-
-									$hasOffsetAccessoryCount++;
-
-									if ($hasOffsetAccessoryCount > self::ARRAY_DIM_FETCH_UNION_HAS_OFFSET_VALUE_TYPE_LIMIT) {
-										$tooManyHasOffsetValueTypes = true;
-										break 2;
-									}
-								}
-							}
-						}
 					}
 
-					if (
-						!$tooManyHasOffsetValueTypes
-						&& ($dimType instanceof ConstantIntegerType || $dimType instanceof ConstantStringType)
-					) {
+					if ($dimType instanceof ConstantIntegerType || $dimType instanceof ConstantStringType) {
 						$varType = TypeCombinator::intersect(
 							$varType,
 							new HasOffsetValueType($dimType, $type),