Take advantage of variadic mergeWith, pt. 1

Author: ondrejmirtes

src/Node/ClassPropertiesNode.php

@@ -26,6 +26,8 @@
 use function array_diff_key;
 use function array_key_exists;
 use function array_keys;
+use function array_slice;
+use function count;
 use function in_array;
 use function strtolower;
 
@@ -269,7 +271,7 @@ private function collectUninitializedProperties(array $constructors, array $unin
 			}
 
 			$returnStatementsNode = $this->returnStatementNodes[$lowerConstructorName];
-			$methodScope = null;
+			$scopesToMerge = [];
 			foreach ($returnStatementsNode->getExecutionEnds() as $executionEnd) {
 				$statementResult = $executionEnd->getStatementResult();
 				$endNode = $executionEnd->getNode();
@@ -281,26 +283,20 @@ private function collectUninitializedProperties(array $constructors, array $unin
 						}
 					}
 				}
-				if ($methodScope === null) {
-					$methodScope = $statementResult->getScope();
-					continue;
-				}
-
-				$methodScope = $methodScope->mergeWith($statementResult->getScope());
+				$scopesToMerge[] = $statementResult->getScope();
 			}
 
 			foreach ($returnStatementsNode->getReturnStatements() as $returnStatement) {
-				if ($methodScope === null) {
-					$methodScope = $returnStatement->getScope();
-					continue;
-				}
-				$methodScope = $methodScope->mergeWith($returnStatement->getScope());
+				$scopesToMerge[] = $returnStatement->getScope();
 			}
 
-			if ($methodScope === null) {
+			if (count($scopesToMerge) === 0) {
 				continue;
 			}
 
+			// @phpstan-ignore method.notFound
+			$methodScope = $scopesToMerge[0]->mergeWith(...array_slice($scopesToMerge, 1));
+
 			foreach (array_keys($uninitializedProperties) as $propertyName) {
 				if (!$methodScope->hasExpressionType(new PropertyInitializationExpr($propertyName))->yes()) {
 					continue;

src/Rules/Properties/SetNonVirtualPropertyHookAssignRule.php

@@ -11,6 +11,8 @@
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\NeverType;
+use function array_slice;
+use function count;
 use function sprintf;
 
 /**
@@ -44,7 +46,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		$finalHookScope = null;
+		$scopesToMerge = [];
 		foreach ($node->getExecutionEnds() as $executionEnd) {
 			$statementResult = $executionEnd->getStatementResult();
 			$endNode = $executionEnd->getNode();
@@ -56,26 +58,20 @@ public function processNode(Node $node, Scope $scope): array
 					}
 				}
 			}
-			if ($finalHookScope === null) {
-				$finalHookScope = $statementResult->getScope();
-				continue;
-			}
-
-			$finalHookScope = $finalHookScope->mergeWith($statementResult->getScope());
+			$scopesToMerge[] = $statementResult->getScope();
 		}
 
 		foreach ($node->getReturnStatements() as $returnStatement) {
-			if ($finalHookScope === null) {
-				$finalHookScope = $returnStatement->getScope();
-				continue;
-			}
-			$finalHookScope = $finalHookScope->mergeWith($returnStatement->getScope());
+			$scopesToMerge[] = $returnStatement->getScope();
 		}
 
-		if ($finalHookScope === null) {
+		if (count($scopesToMerge) === 0) {
 			return [];
 		}
 
+		// @phpstan-ignore method.notFound
+		$finalHookScope = $scopesToMerge[0]->mergeWith(...array_slice($scopesToMerge, 1));
+
 		$initExpr = new PropertyInitializationExpr($propertyName);
 		$hasInit = $finalHookScope->hasExpressionType($initExpr);
 		if ($hasInit->yes()) {

src/Rules/TooWideTypehints/TooWideParameterOutTypeCheck.php

@@ -9,6 +9,8 @@
 use PHPStan\Node\ReturnStatement;
 use PHPStan\Reflection\ExtendedParameterReflection;
 use PHPStan\Rules\IdentifierRuleError;
+use function array_slice;
+use function count;
 use function lcfirst;
 use function sprintf;
 
@@ -36,30 +38,22 @@ public function check(
 		string $functionDescription,
 	): array
 	{
-		$finalScope = null;
+		$scopesToMerge = [];
 		foreach ($executionEnds as $executionEnd) {
-			$endScope = $executionEnd->getStatementResult()->getScope();
-			if ($finalScope === null) {
-				$finalScope = $endScope;
-				continue;
-			}
-
-			$finalScope = $finalScope->mergeWith($endScope);
+			$scopesToMerge[] = $executionEnd->getStatementResult()->getScope();
 		}
 
 		foreach ($returnStatements as $statement) {
-			if ($finalScope === null) {
-				$finalScope = $statement->getScope();
-				continue;
-			}
-
-			$finalScope = $finalScope->mergeWith($statement->getScope());
+			$scopesToMerge[] = $statement->getScope();
 		}
 
-		if ($finalScope === null) {
+		if (count($scopesToMerge) === 0) {
 			return [];
 		}
 
+		// @phpstan-ignore method.notFound
+		$finalScope = $scopesToMerge[0]->mergeWith(...array_slice($scopesToMerge, 1));
+
 		$errors = [];
 		foreach ($parameters as $parameter) {
 			if (!$parameter->passedByReference()->createsNewVariable()) {