Update dynamic-static-call.php

staabm · staabm · commit 09c0a7503392 · 2026-02-20T17:29:18.000+01:00
diff --git a/tests/PHPStan/Rules/Methods/data/dynamic-static-call.php b/tests/PHPStan/Rules/Methods/data/dynamic-static-call.php
@@ -29,8 +29,8 @@ final static public function finalFoo():int
 
 class Baz {
 	function doBaz(Foo $foo, FinalFoo $finalFoo, Bar $bar):void {
-		$foo::doFoo();
-		$finalFoo::doFoo();
-		$bar::finalFoo();
+		$foo::doFoo(); // no error, subclass could override static method with impure impl
+		$finalFoo::doFoo(); // could error, because final class
+		$bar::finalFoo(); // could error, because final method
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,8 @@ final static public function finalFoo():int`
`29`	`29`
`30`	`30`	`class Baz {`
`31`	`31`	`function doBaz(Foo $foo, FinalFoo $finalFoo, Bar $bar):void {`
`32`		`- $foo::doFoo();`
`33`		`- $finalFoo::doFoo();`
`34`		`- $bar::finalFoo();`
	`32`	`+ $foo::doFoo(); // no error, subclass could override static method with impure impl`
	`33`	`+ $finalFoo::doFoo(); // could error, because final class`
	`34`	`+ $bar::finalFoo(); // could error, because final method`
`35`	`35`	`}`
`36`	`36`	`}`