Fix phpstan/phpstan#9349: Throw point are not properly recognized (#5166)

Co-authored-by: ondrejmirtes <104888+ondrejmirtes@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: 3 people

src/Analyser/NodeScopeResolver.php

@@ -1878,6 +1878,7 @@ public function processStmtNode(
 
 				// explicit only
 				$onlyExplicitIsThrow = true;
+				$hasDirectExplicitNonThrowMatch = false;
 				if (count($matchingThrowPoints) === 0) {
 					foreach ($throwPoints as $throwPointIndex => $throwPoint) {
 						foreach ($catchTypes as $catchTypeIndex => $catchTypeItem) {
@@ -1895,14 +1896,17 @@ public function processStmtNode(
 								&& !($throwNode instanceof Node\Stmt\Expression && $throwNode->expr instanceof Expr\Throw_)
 							) {
 								$onlyExplicitIsThrow = false;
+								if ($catchTypeItem->isSuperTypeOf($throwPoint->getType())->yes()) {
+									$hasDirectExplicitNonThrowMatch = true;
+								}
 							}
 							$matchingThrowPoints[$throwPointIndex] = $throwPoint;
 						}
 					}
 				}
 
 				// implicit only
-				if (count($matchingThrowPoints) === 0 || $onlyExplicitIsThrow) {
+				if (count($matchingThrowPoints) === 0 || $onlyExplicitIsThrow || !$hasDirectExplicitNonThrowMatch) {
 					foreach ($throwPoints as $throwPointIndex => $throwPoint) {
 						if ($throwPoint->isExplicit()) {
 							continue;

tests/PHPStan/Rules/Variables/DefinedVariableRuleTest.php

@@ -1403,6 +1403,25 @@ public function testBug14019(): void
 		$this->analyse([__DIR__ . '/../../Analyser/nsrt/bug-14019.php'], []);
 	}
 
+	public function testBug9349(): void
+	{
+		$this->cliArgumentsVariablesRegistered = true;
+		$this->polluteScopeWithLoopInitialAssignments = false;
+		$this->checkMaybeUndefinedVariables = true;
+		$this->polluteScopeWithAlwaysIterableForeach = true;
+
+		$this->analyse([__DIR__ . '/data/bug-9349.php'], [
+			[
+				'Variable $sql might not be defined.',
+				19,
+			],
+			[
+				'Variable $sql might not be defined.',
+				78,
+			],
+		]);
+	}
+
 	#[RequiresPhp('>= 8.0')]
 	public function testBug14274(): void
 	{

tests/PHPStan/Rules/Variables/data/bug-9349.php

@@ -0,0 +1,94 @@
+<?php declare(strict_types = 1);
+
+namespace Bug9349;
+
+class HelloWorld
+{
+	public function test(): void
+	{
+		global $pdo;
+
+		try {
+			$this->maybeThrows();
+			$sql = "SELECT * FROM foo";
+			$rs = $pdo->query($sql);
+			if ($result = $rs->fetch(\PDO::FETCH_ASSOC)) {
+				// do something
+			}
+		} catch (\PDOException $e) {
+			var_dump($sql);
+		}
+	}
+
+	/**
+	 * @throws \RuntimeException
+	 */
+	public function maybeThrows(): void
+	{
+		if (random_int(0, 1) === 1) {
+			throw new \RuntimeException();
+		}
+	}
+
+}
+
+class HelloWorld2
+{
+	public function test2(): void
+	{
+		global $pdo;
+
+		try {
+			$this->maybeThrows2();
+			$sql = "SELECT * FROM foo";
+			$rs = $pdo->query($sql);
+			if ($result = $rs->fetch(\PDO::FETCH_ASSOC)) {
+				// do something
+			}
+		} catch (\PDOException $e) {
+			var_dump($sql);
+		}
+	}
+
+	/**
+	 * @throws \LogicException
+	 */
+	public function maybeThrows2(): void
+	{
+		if (random_int(0, 1) === 1) {
+			throw new \LogicException();
+		}
+	}
+}
+
+class HelloWorld3
+{
+	public function test3(): void
+	{
+		global $pdo;
+
+		try {
+			$this->maybeThrows3();
+			$sql = "SELECT * FROM foo";
+			$rs = $pdo->query($sql);
+			if ($result = $rs->fetch(\PDO::FETCH_ASSOC)) {
+				// do something
+			}
+		} catch (\PDOException $e) {
+			var_dump($sql);
+		}
+	}
+
+	/**
+	 * @throws \LogicException|\RuntimeException
+	 */
+	public function maybeThrows3(): void
+	{
+		if (random_int(0, 1) === 1) {
+			throw new \RuntimeException();
+		}
+		if (random_int(0, 1) === 1) {
+			throw new \LogicException();
+		}
+	}
+}