Fix phpstan/phpstan#12062: False positive "has no effect" on static:: call to overridable method

- Skip collecting static:: calls in PossiblyPureStaticCallCollector when the method can be overridden
- A subclass may override the method with side effects, so the call cannot be assumed pure
- Updated existing test expectations for static:: calls in non-final classes
- New regression test in tests/PHPStan/Rules/DeadCode/data/bug-12062.php

Author: github-actions[bot]

src/Rules/DeadCode/PossiblyPureStaticCallCollector.php

@@ -63,6 +63,16 @@ public function processNode(Node $node, Scope $scope)
 			return null;
 		}
 
+		if (
+			$expr->class->toLowerString() === 'static'
+			&& $scope->isInClass()
+			&& !$scope->getClassReflection()->isFinal()
+			&& !$methodReflection->isFinal()->yes()
+			&& !$methodReflection->isPrivate()
+		) {
+			return null;
+		}
+
 		return [$methodReflection->getDeclaringClass()->getName(), $methodReflection->getName(), $node->getStartLine()];
 	}
 

tests/PHPStan/Rules/DeadCode/CallToStaticMethodStatementWithoutImpurePointsRuleTest.php

@@ -44,10 +44,6 @@ public function testRule(): void
 				'Call to CallToStaticMethodWithoutImpurePoints\SubSubY::mySubSubFunc() on a separate line has no effect.',
 				21,
 			],
-			[
-				'Call to CallToStaticMethodWithoutImpurePoints\y::myFunc() on a separate line has no effect.',
-				48,
-			],
 			[
 				'Call to CallToStaticMethodWithoutImpurePoints\y::myFunc() on a separate line has no effect.',
 				53,
@@ -59,6 +55,11 @@ public function testRule(): void
 		]);
 	}
 
+	public function testBug12062(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-12062.php'], []);
+	}
+
 	#[RequiresPhp('>= 8.5')]
 	public function testPipeOperator(): void
 	{

tests/PHPStan/Rules/DeadCode/data/bug-12062.php

@@ -0,0 +1,38 @@
+<?php declare(strict_types=1);
+
+namespace Bug12062;
+
+abstract class Base
+{
+	public static function get(mixed $param): mixed
+	{
+		static::validateParam($param);
+		return $param;
+	}
+
+	public static function set(mixed $param, mixed $value): void
+	{
+		static::validateParam($param);
+	}
+
+	public static function clear(mixed $param): void
+	{
+		static::validateParam($param);
+	}
+
+	protected static function validateParam(mixed $param): bool
+	{
+		return true;
+	}
+}
+
+abstract class IntParam extends Base
+{
+	protected static function validateParam(mixed $param): bool
+	{
+		if (!is_int($param)) {
+			throw new \InvalidArgumentException('Must be int');
+		}
+		return true;
+	}
+}