Skip to content

Commit 101b456

Browse files
author
B.J. Scharp
committed
fix: Corrected metadata & stub for SplHeap & SplFixedArray
1 parent 28f6ffe commit 101b456

3 files changed

Lines changed: 10 additions & 12 deletions

File tree

bin/functionMetadata_original.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -315,11 +315,11 @@
315315
'SplFileObject::ftruncate' => ['hasSideEffects' => true],
316316
'SplFileObject::fwrite' => ['hasSideEffects' => true],
317317

318-
'SplFixedArray::extract' => ['hasSideEffects' => true],
318+
'SplFixedArray::setSize' => ['hasSideEffects' => true],
319319

320-
'SplHead::extract' => ['hasSideEffects' => true],
321-
'SplHead::insert' => ['hasSideEffects' => true],
322-
'SplHead::recoverFromCorruption' => ['hasSideEffects' => true],
320+
'SplHeap::extract' => ['hasSideEffects' => true],
321+
'SplHeap::insert' => ['hasSideEffects' => true],
322+
'SplHeap::recoverFromCorruption' => ['hasSideEffects' => true],
323323

324324
'SplObjectStorage::addAll' => ['hasSideEffects' => true],
325325
'SplObjectStorage::attach' => ['hasSideEffects' => true],

resources/functionMetadata.php

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,6 @@
570570
'ReflectionMethod::isProtected' => ['hasSideEffects' => false],
571571
'ReflectionMethod::isPublic' => ['hasSideEffects' => false],
572572
'ReflectionMethod::isStatic' => ['hasSideEffects' => false],
573-
'ReflectionMethod::setAccessible' => ['hasSideEffects' => false],
574573
'ReflectionNamedType::getName' => ['hasSideEffects' => false],
575574
'ReflectionNamedType::isBuiltin' => ['hasSideEffects' => false],
576575
'ReflectionParameter::getAttributes' => ['hasSideEffects' => false],
@@ -605,7 +604,6 @@
605604
'ReflectionProperty::isProtected' => ['hasSideEffects' => false],
606605
'ReflectionProperty::isPublic' => ['hasSideEffects' => false],
607606
'ReflectionProperty::isStatic' => ['hasSideEffects' => false],
608-
'ReflectionProperty::setAccessible' => ['hasSideEffects' => false],
609607
'ReflectionReference::getId' => ['hasSideEffects' => false],
610608
'ReflectionType::isBuiltin' => ['hasSideEffects' => false],
611609
'ReflectionUnionType::getTypes' => ['hasSideEffects' => false],
@@ -653,10 +651,10 @@
653651
'SplFileObject::fseek' => ['hasSideEffects' => true],
654652
'SplFileObject::ftruncate' => ['hasSideEffects' => true],
655653
'SplFileObject::fwrite' => ['hasSideEffects' => true],
656-
'SplFixedArray::extract' => ['hasSideEffects' => true],
657-
'SplHead::extract' => ['hasSideEffects' => true],
658-
'SplHead::insert' => ['hasSideEffects' => true],
659-
'SplHead::recoverFromCorruption' => ['hasSideEffects' => true],
654+
'SplFixedArray::setSize' => ['hasSideEffects' => true],
655+
'SplHeap::extract' => ['hasSideEffects' => true],
656+
'SplHeap::insert' => ['hasSideEffects' => true],
657+
'SplHeap::recoverFromCorruption' => ['hasSideEffects' => true],
660658
'SplObjectStorage::addAll' => ['hasSideEffects' => true],
661659
'SplObjectStorage::attach' => ['hasSideEffects' => true],
662660
'SplObjectStorage::detach' => ['hasSideEffects' => true],
@@ -1758,4 +1756,4 @@
17581756
'zlib_encode' => ['hasSideEffects' => false],
17591757
'zlib_get_coding_type' => ['hasSideEffects' => false],
17601758

1761-
];
1759+
];

stubs/ArrayObject.stub

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ class SplFixedArray implements Iterator, IteratorAggregate, ArrayAccess, Countab
9999
* @param array<int, TInput> $array
100100
* @return SplFixedArray<TInput>
101101
*/
102-
public static function fromArray(array $array, bool $save_indexes = true): SplFixedArray { }
102+
public static function fromArray(array $array, bool $preserveKeys = true): SplFixedArray { }
103103

104104
/**
105105
* @return array<int, TValue|null>

0 commit comments

Comments
 (0)