Add rule tests for bug 14446 to verify no false positives

Add StrictComparisonOfDifferentTypesRule test with
polluteScopeWithAlwaysIterableForeach: false to ensure no
"Strict comparison using === between false and true" error.

Add integration-style rule test in Bug14446Test that runs full
analysis with OverwriteVariablesWithForeachRule registered,
verifying no "Foreach overwrites $key" false positive.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

tests/PHPStan/Analyser/Bug14446Test.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Analyser;
 
+use PHPStan\File\FileHelper;
 use PHPStan\Testing\TypeInferenceTestCase;
 use PHPUnit\Framework\Attributes\DataProvider;
 
@@ -33,4 +34,19 @@ public static function getAdditionalConfigFiles(): array
 		];
 	}
 
+	public function testRule(): void
+	{
+		$file = self::getContainer()->getByType(FileHelper::class)->normalizePath(__DIR__ . '/data/bug-14446-rule.php');
+
+		$analyser = self::getContainer()->getByType(Analyser::class);
+		$finalizer = self::getContainer()->getByType(AnalyserResultFinalizer::class);
+		$errors = $finalizer->finalize(
+			$analyser->analyse([$file], null, null, true),
+			false,
+			true,
+		)->getErrors();
+
+		$this->assertNoErrors($errors);
+	}
+
 }

tests/PHPStan/Analyser/bug-14446.neon

@@ -1,2 +1,8 @@
 parameters:
 	polluteScopeWithAlwaysIterableForeach: false
+
+services:
+	-
+		class: PHPStan\Rules\ForeachLoop\OverwriteVariablesWithForeachRule
+		tags:
+			- phpstan.rules.rule

tests/PHPStan/Analyser/data/bug-14446-rule.php

@@ -0,0 +1,57 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14446Rule;
+
+function test(bool $initial): void {
+	$current = $initial;
+
+	while (true) {
+		if (!$current) {
+			break;
+		}
+
+		$items = [1];
+		foreach ($items as $item) {
+			$current = false;
+		}
+	}
+
+	var_dump($initial === true);
+}
+
+function testMaybeIterable(bool $initial): void {
+	$current = $initial;
+
+	while (true) {
+		if (!$current) {
+			break;
+		}
+
+		$items = rand() > 0 ? [1] : [];
+		foreach ($items as $item) {
+			$current = false;
+		}
+	}
+
+	var_dump($initial === true);
+}
+
+/**
+ * @param mixed $value
+ */
+function testForeachKeyOverwrite($value): void {
+	if (is_array($value) && $value !== []) {
+		$hasOnlyStringKey = true;
+		foreach (array_keys($value) as $key) {
+			if (is_int($key)) {
+				$hasOnlyStringKey = false;
+				break;
+			}
+		}
+
+		if ($hasOnlyStringKey) {
+			foreach ($value as $key => $element) {
+			}
+		}
+	}
+}

tests/PHPStan/Rules/Comparison/StrictComparisonOfDifferentTypesRuleTest.php

@@ -20,6 +20,8 @@ class StrictComparisonOfDifferentTypesRuleTest extends RuleTestCase
 
 	private bool $treatPhpDocTypesAsCertain = true;
 
+	private bool $polluteScopeWithAlwaysIterableForeach = true;
+
 	protected function getRule(): Rule
 	{
 		return new StrictComparisonOfDifferentTypesRule(
@@ -36,6 +38,11 @@ protected function shouldTreatPhpDocTypesAsCertain(): bool
 		return $this->treatPhpDocTypesAsCertain;
 	}
 
+	protected function shouldPolluteScopeWithAlwaysIterableForeach(): bool
+	{
+		return $this->polluteScopeWithAlwaysIterableForeach;
+	}
+
 	public function testStrictComparison(): void
 	{
 		$tipText = 'Because the type is coming from a PHPDoc, you can turn off this check by setting <fg=cyan>treatPhpDocTypesAsCertain: false</> in your <fg=cyan>%configurationFile%</>.';
@@ -1184,4 +1191,10 @@ public function testBug13421(): void
 		$this->analyse([__DIR__ . '/../../Analyser/nsrt/bug-13421.php'], []);
 	}
 
+	public function testBug14446(): void
+	{
+		$this->polluteScopeWithAlwaysIterableForeach = false;
+		$this->analyse([__DIR__ . '/data/bug-14446.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-14446.php

@@ -0,0 +1,37 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14446Rule;
+
+function test(bool $initial): void {
+	$current = $initial;
+
+	while (true) {
+		if (!$current) {
+			break;
+		}
+
+		$items = [1];
+		foreach ($items as $item) {
+			$current = false;
+		}
+	}
+
+	var_dump($initial === true);
+}
+
+function testMaybeIterable(bool $initial): void {
+	$current = $initial;
+
+	while (true) {
+		if (!$current) {
+			break;
+		}
+
+		$items = rand() > 0 ? [1] : [];
+		foreach ($items as $item) {
+			$current = false;
+		}
+	}
+
+	var_dump($initial === true);
+}