regression tests

Author: staabm

tests/PHPStan/Analyser/nsrt/bug-10422.php

@@ -0,0 +1,42 @@
+<?php declare(strict_types = 1);
+
+namespace Bug10422;
+
+use stdClass;
+use function PHPStan\Testing\assertType;
+
+class Foo
+{
+
+	public function something(): bool
+	{
+		return true;
+	}
+
+	public function test(): void
+	{
+	}
+
+}
+
+function createOrNotObject(): ?Foo
+{
+	return new Foo();
+}
+
+function testSimple(): void
+{
+	$test = createOrNotObject();
+
+	$error = '';
+
+	if (!$test) {
+		$error = 'missing test';
+	} else if ($test->something()) {
+		$error = 'another';
+	}
+	if ($error) {
+		die('Done');
+	}
+	assertType(Foo::class, $test);
+}

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -1851,6 +1851,11 @@ public function testBug10527(): void
 		$this->analyse([__DIR__ . '/data/bug-10527.php'], []);
 	}
 
+	public function testBug10055(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-10055.php'], []);
+	}
+
 	public function testBug10626(): void
 	{
 		$this->analyse([__DIR__ . '/data/bug-10626.php'], [

tests/PHPStan/Rules/Functions/data/bug-10055.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Bug10055;
+
+function expectInt(int $param): void
+{
+}
+
+function expectBool(bool $param): void
+{
+}
+
+/**
+ * @param 'value1'|'value2'|'value3' $param1
+ * @param ($param1 is 'value3' ? bool : int) $param2
+ */
+function test(string $param1, int|bool $param2): void
+{
+	match ($param1) {
+		'value1' => expectInt($param2),
+		'value2' => expectInt($param2),
+		'value3' => expectBool($param2),
+	};
+}

tests/PHPStan/Rules/Variables/DefinedVariableRuleTest.php

@@ -1476,6 +1476,25 @@ public function testBug14227(): void
 		$this->analyse([__DIR__ . '/data/bug-14227.php'], []);
 	}
 
+	public function testBug12597(): void
+	{
+		$this->cliArgumentsVariablesRegistered = true;
+		$this->polluteScopeWithLoopInitialAssignments = false;
+		$this->checkMaybeUndefinedVariables = true;
+		$this->polluteScopeWithAlwaysIterableForeach = true;
+		$this->analyse([__DIR__ . '/data/bug-12597.php'], []);
+	}
+
+	#[RequiresPhp('>= 8.0')]
+	public function testBug12597NonFinite(): void
+	{
+		$this->cliArgumentsVariablesRegistered = true;
+		$this->polluteScopeWithLoopInitialAssignments = false;
+		$this->checkMaybeUndefinedVariables = true;
+		$this->polluteScopeWithAlwaysIterableForeach = true;
+		$this->analyse([__DIR__ . '/data/bug-12597-non-finite.php'], []);
+	}
+
 	public function testBug14117(): void
 	{
 		$this->cliArgumentsVariablesRegistered = true;
@@ -1499,4 +1518,14 @@ public function testBug14117(): void
 		]);
 	}
 
+	public function testBug11218(): void
+	{
+		$this->cliArgumentsVariablesRegistered = true;
+		$this->polluteScopeWithLoopInitialAssignments = false;
+		$this->checkMaybeUndefinedVariables = true;
+		$this->polluteScopeWithAlwaysIterableForeach = true;
+
+		$this->analyse([__DIR__ . '/data/bug-11218.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Variables/data/bug-11218.php

@@ -0,0 +1,29 @@
+<?php declare(strict_types = 1);
+
+namespace Bug11218;
+
+function doFoo() {
+	$level = 'test';
+
+	for ($i = 0 ; $i <= 3 ; $i++) {
+		if ($i === 0) {
+			$test[$level] = 'this is a';
+		} else {
+			$test[$level] .= ' test';
+		}
+	}
+}
+
+function doBar() {
+	$level = 'test';
+
+	$test = [];
+
+	for ($i = 0 ; $i <= 3 ; $i++) {
+		if ($i === 0) {
+			$test[$level] = 'this is a';
+		} else {
+			$test[$level] .= ' test';
+		}
+	}
+}

tests/PHPStan/Rules/Variables/data/bug-12597-non-finite.php

@@ -0,0 +1,51 @@
+<?php declare(strict_types = 1);
+
+namespace Bug12597NonFinite;
+
+class HelloWorld
+{
+	public function test(mixed $type): void
+	{
+		if (is_int($type) || is_string($type)) {
+			$message = 'Hello!';
+		}
+
+		if (is_int($type)) {
+			$this->message($message);
+		}
+	}
+
+	public function message(string $message): void {}
+}
+
+class Foo {}
+class Bar {}
+
+class HelloWorld2
+{
+	public function test(mixed $type): void
+	{
+		if (is_int($type) || is_object($type)) {
+			$message = 'Hello!';
+		}
+
+		if (is_int($type)) {
+			$this->message($message);
+		}
+	}
+
+	public function test2(mixed $type): void
+	{
+		if ($type instanceof Foo || $type instanceof Bar) {
+			$message = 'Hello!';
+		}
+
+		if ($type instanceof Foo) {
+			$this->message($message);
+		}
+	}
+
+	public function message(string $message): void
+	{
+	}
+}

tests/PHPStan/Rules/Variables/data/bug-12597.php

@@ -0,0 +1,22 @@
+<?php declare(strict_types = 1);
+
+namespace Bug12597;
+
+class HelloWorld
+{
+	private const TYPE_1 = 1;
+	private const TYPE_2 = 2;
+
+	public function test(int $type): void
+	{
+		if (in_array($type, [self::TYPE_1, self::TYPE_2], true)) {
+			$message = 'Hello!';
+		}
+
+		if ($type === self::TYPE_1) {
+			$this->message($message);
+		}
+	}
+
+	public function message(string $message): void {}
+}