fix

Author: staabm

src/Rules/Variables/InvalidVariableAssignRule.php

@@ -32,11 +32,12 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		if ($variable->name === 'this') {
-			$expr = $node->getAssignedExpr();
-			$type = $scope->getType($expr);
+			if ($scope->isInClass()) {
+				$classReflection = $scope->getClassReflection();
 
-			if ((new ObjectType(ArrayAccess::class))->isSuperTypeOf($type)->yes()) {
-				return [];
+				if ($classReflection->is(ArrayAccess::class)) {
+					return [];
+				}
 			}
 
 			return [

tests/PHPStan/Rules/Variables/InvalidVariableAssignRuleTest.php

@@ -55,14 +55,36 @@ public function testBug3585(): void
 	public function testBug14352(): void
 	{
 		$this->analyse([__DIR__ . '/data/bug-14352.php'], [
+			/*
 			[
 				'Cannot re-assign $this.',
 				13,
 			],
+			*/
 			[
 				'Cannot re-assign $this.',
 				37,
 			],
+			[
+				'Cannot re-assign $this.',
+				39,
+			],
+			[
+				'Cannot re-assign $this.',
+				47,
+			],
+			[
+				'Cannot re-assign $this.',
+				49,
+			],
+			[
+				'Cannot re-assign $this.',
+				57,
+			],
+			[
+				'Cannot re-assign $this.',
+				63,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Variables/data/bug-14352.php

@@ -35,6 +35,8 @@ final class FinalTestPlain
 	public function doFoo(string $key, string $value): void
 	{
 		$this[$key] = $value;
+
+		$this = $value;
 	}
 }
 
@@ -43,5 +45,20 @@ class TestPlain
 	public function doFoo(string $key, string $value): void
 	{
 		$this[$key] = $value;
+
+		$this = $value;
+	}
+}
+
+class TestStatic
+{
+	static public function doFoo(string $value): void
+	{
+		$this = $value;
 	}
 }
+
+function doFoo(string $value): void
+{
+	$this = $value;
+}