Add scope parameter to InternalThrowPoint::createFromPublic instead of replaceScope

Make the $scope parameter required (non-nullable) since it is always
provided at the only call site.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

src/Analyser/InternalThrowPoint.php

@@ -3,7 +3,6 @@
 namespace PHPStan\Analyser;
 
 use PhpParser\Node;
-use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
@@ -50,15 +49,8 @@ public static function createImplicit(MutatingScope $scope, Node $node): self
 		return new self($scope, new ObjectType(Throwable::class), $node, explicit: false, canContainAnyThrowable: true);
 	}
 
-	public static function createFromPublic(ThrowPoint $throwPoint, ?MutatingScope $scope = null): self
+	public static function createFromPublic(ThrowPoint $throwPoint, MutatingScope $scope): self
 	{
-		if ($scope === null) {
-			$scope = $throwPoint->getScope();
-			if (!$scope instanceof MutatingScope) {
-				throw new ShouldNotHappenException();
-			}
-		}
-
 		return new self($scope, $throwPoint->getType(), $throwPoint->getNode(), $throwPoint->isExplicit(), $throwPoint->canContainAnyThrowable());
 	}