Conditional return type for SQLite3Result::fetchArray() and SQLite3Result::fetchAll()

Author: devnix

bin/functionMetadata_original.php

@@ -333,6 +333,8 @@
 
 	'SplQueue::dequeue' => ['hasSideEffects' => true],
 
+	'SQLite3Result::fetchArray' => ['hasSideEffects' => true],
+
 	'XmlReader::next' => ['hasSideEffects' => true],
 	'XmlReader::read' => ['hasSideEffects' => true],
 ];

resources/functionMap.php

@@ -10062,7 +10062,7 @@
 'SQLite3Result::__construct' => ['void'],
 'SQLite3Result::columnName' => ['string', 'column_number'=>'int'],
 'SQLite3Result::columnType' => ['int', 'column_number'=>'int'],
-'SQLite3Result::fetchArray' => ['array|false', 'mode='=>'int'],
+'SQLite3Result::fetchArray' => ['($mode is SQLITE3_NUM ? non-empty-list<mixed>|false : ($mode is SQLITE3_ASSOC ? non-empty-array<string,mixed>|false : non-empty-array<int|string,mixed>|false))', 'mode='=>'int'],
 'SQLite3Result::finalize' => ['bool'],
 'SQLite3Result::numColumns' => ['int'],
 'SQLite3Result::reset' => ['bool'],

resources/functionMap_php85delta.php

@@ -16,6 +16,7 @@
 return [
 	'new' => [
 		'chr' => ['non-empty-string', 'ascii'=>'int<0,255>'],
+		'SQLite3Result::fetchAll' => ['($mode is SQLITE3_NUM ? list<non-empty-list<mixed>>|false : ($mode is SQLITE3_ASSOC ? list<non-empty-array<string,mixed>>|false : list<non-empty-array<int|string,mixed>>|false))', 'mode='=>'int'],
 	],
 	'old' => [
 		'chr' => ['non-empty-string', 'ascii'=>'int'],

resources/functionMetadata.php

@@ -570,7 +570,6 @@
 	'ReflectionMethod::isProtected' => ['hasSideEffects' => false],
 	'ReflectionMethod::isPublic' => ['hasSideEffects' => false],
 	'ReflectionMethod::isStatic' => ['hasSideEffects' => false],
-	'ReflectionMethod::setAccessible' => ['hasSideEffects' => false],
 	'ReflectionNamedType::getName' => ['hasSideEffects' => false],
 	'ReflectionNamedType::isBuiltin' => ['hasSideEffects' => false],
 	'ReflectionParameter::getAttributes' => ['hasSideEffects' => false],
@@ -605,7 +604,6 @@
 	'ReflectionProperty::isProtected' => ['hasSideEffects' => false],
 	'ReflectionProperty::isPublic' => ['hasSideEffects' => false],
 	'ReflectionProperty::isStatic' => ['hasSideEffects' => false],
-	'ReflectionProperty::setAccessible' => ['hasSideEffects' => false],
 	'ReflectionReference::getId' => ['hasSideEffects' => false],
 	'ReflectionType::isBuiltin' => ['hasSideEffects' => false],
 	'ReflectionUnionType::getTypes' => ['hasSideEffects' => false],
@@ -620,6 +618,7 @@
 	'ResourceBundle::getErrorCode' => ['hasSideEffects' => false],
 	'ResourceBundle::getErrorMessage' => ['hasSideEffects' => false],
 	'ResourceBundle::getIterator' => ['hasSideEffects' => false],
+	'SQLite3Result::fetchArray' => ['hasSideEffects' => true],
 	'SQLiteException::__construct' => ['hasSideEffects' => false],
 	'SimpleXMLElement::__construct' => ['hasSideEffects' => false],
 	'SimpleXMLElement::children' => ['hasSideEffects' => false],
@@ -1758,4 +1757,4 @@
 	'zlib_encode' => ['hasSideEffects' => false],
 	'zlib_get_coding_type' => ['hasSideEffects' => false],
 
-];
+];

tests/PHPStan/Analyser/nsrt/sqlite3-result-fetch-all-php85.php

@@ -0,0 +1,31 @@
+<?php // php >= 8.5
+
+namespace Sqlite3ResultFetchAll;
+
+use SQLite3Result;
+use function PHPStan\Testing\assertType;
+
+class Foo
+{
+
+	public function fetchAllDefault(SQLite3Result $result): void
+	{
+		assertType('list<non-empty-array<int|string, mixed>>|false', $result->fetchAll());
+	}
+
+	public function fetchAllBoth(SQLite3Result $result): void
+	{
+		assertType('list<non-empty-array<int|string, mixed>>|false', $result->fetchAll(SQLITE3_BOTH));
+	}
+
+	public function fetchAllNum(SQLite3Result $result): void
+	{
+		assertType('list<non-empty-list<mixed>>|false', $result->fetchAll(SQLITE3_NUM));
+	}
+
+	public function fetchAllAssoc(SQLite3Result $result): void
+	{
+		assertType('list<non-empty-array<string, mixed>>|false', $result->fetchAll(SQLITE3_ASSOC));
+	}
+
+}

tests/PHPStan/Analyser/nsrt/sqlite3-result-fetch-array.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace Sqlite3ResultFetchArray;
+
+use SQLite3Result;
+use function PHPStan\Testing\assertType;
+
+class Foo
+{
+
+	public function fetchArrayDefault(SQLite3Result $result): void
+	{
+		assertType('non-empty-array<int|string, mixed>|false', $result->fetchArray());
+	}
+
+	public function fetchArrayBoth(SQLite3Result $result): void
+	{
+		assertType('non-empty-array<int|string, mixed>|false', $result->fetchArray(SQLITE3_BOTH));
+	}
+
+	public function fetchArrayNum(SQLite3Result $result): void
+	{
+		assertType('non-empty-list<mixed>|false', $result->fetchArray(SQLITE3_NUM));
+	}
+
+	public function fetchArrayAssoc(SQLite3Result $result): void
+	{
+		assertType('non-empty-array<string, mixed>|false', $result->fetchArray(SQLITE3_ASSOC));
+	}
+
+}