Add isFirstClassCallable() guards in resolveNormalizedIdentical and expand tests

Add missing guards for strlen/mb_strlen, array_key_first/array_key_last,
get_class/get_debug_type, and substr/strstr/etc patterns in
resolveNormalizedIdentical that were not covered by the initial fix.

Expand tests to cover all affected functions: strlen, mb_strlen, count,
sizeof, preg_match, gettype, get_class, get_debug_type, get_parent_class,
trim, ltrim, rtrim, array_keys (foreach), and count (for-loop). Tests
exercise both assignment and comparison/equality code paths.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

src/Analyser/TypeSpecifier.php

@@ -2996,9 +2996,10 @@ private function resolveNormalizedIdentical(Expr\BinaryOp\Identical $expr, Scope
 		if (
 			!$context->null()
 			&& $unwrappedLeftExpr instanceof FuncCall
-			&& count($unwrappedLeftExpr->getArgs()) === 1
 			&& $unwrappedLeftExpr->name instanceof Name
+			&& !$unwrappedLeftExpr->isFirstClassCallable()
 			&& in_array(strtolower((string) $unwrappedLeftExpr->name), ['strlen', 'mb_strlen'], true)
+			&& count($unwrappedLeftExpr->getArgs()) === 1
 			&& $rightType->isInteger()->yes()
 		) {
 			if (IntegerRangeType::fromInterval(null, -1)->isSuperTypeOf($rightType)->yes()) {
@@ -3034,6 +3035,7 @@ private function resolveNormalizedIdentical(Expr\BinaryOp\Identical $expr, Scope
 		if (
 			$unwrappedLeftExpr instanceof FuncCall
 			&& $unwrappedLeftExpr->name instanceof Name
+			&& !$unwrappedLeftExpr->isFirstClassCallable()
 			&& in_array($unwrappedLeftExpr->name->toLowerString(), ['array_key_first', 'array_key_last'], true)
 			&& isset($unwrappedLeftExpr->getArgs()[0])
 			&& $rightType->isNull()->yes()
@@ -3065,6 +3067,7 @@ private function resolveNormalizedIdentical(Expr\BinaryOp\Identical $expr, Scope
 			$context->true()
 			&& $unwrappedLeftExpr instanceof FuncCall
 			&& $unwrappedLeftExpr->name instanceof Name
+			&& !$unwrappedLeftExpr->isFirstClassCallable()
 			&& in_array(strtolower($unwrappedLeftExpr->name->toString()), ['get_class', 'get_debug_type'], true)
 			&& isset($unwrappedLeftExpr->getArgs()[0])
 		) {
@@ -3090,6 +3093,7 @@ private function resolveNormalizedIdentical(Expr\BinaryOp\Identical $expr, Scope
 			$context->truthy()
 			&& $unwrappedLeftExpr instanceof FuncCall
 			&& $unwrappedLeftExpr->name instanceof Name
+			&& !$unwrappedLeftExpr->isFirstClassCallable()
 			&& in_array(strtolower($unwrappedLeftExpr->name->toString()), [
 				'substr', 'strstr', 'stristr', 'strchr', 'strrchr', 'strtolower', 'strtoupper', 'ucfirst', 'lcfirst',
 				'mb_substr', 'mb_strstr', 'mb_stristr', 'mb_strchr', 'mb_strrchr', 'mb_strtolower', 'mb_strtoupper', 'mb_ucfirst', 'mb_lcfirst',

tests/PHPStan/Analyser/nsrt/bug-14550.php

@@ -42,80 +42,122 @@ function crashArraySearch(array $list, string $s): void
 	assertType('Closure(mixed, array, bool=): (int|string|false)', $fn);
 }
 
-function crashCount(): void
+function testStrlen(): void
 {
-	$fn = count(...);
-	assertType('Closure(array|Countable, 0|1=): int<0, max>', $fn);
+	$fn = strlen(...);
+	assertType('Closure(string): int<0, max>', $fn);
+
+	if (strlen(...) < 1) {}
+	if (0 < strlen(...)) {}
 }
 
-function crashSizeof(): void
+function testMbStrlen(): void
 {
-	$fn = sizeof(...);
-	assertType('Closure(array|Countable, int=): int', $fn);
+	$fn = mb_strlen(...);
+	assertType('Closure(string, string|null=): int<0, max>', $fn);
+
+	if (mb_strlen(...) < 1) {}
+	if (0 < mb_strlen(...)) {}
 }
 
-function crashStrlen(): void
+function testCount(): void
 {
-	$fn = strlen(...);
-	assertType('Closure(string): int<0, max>', $fn);
+	$fn = count(...);
+	assertType('Closure(array|Countable, 0|1=): int<0, max>', $fn);
+
+	if (count(...) < 1) {}
+	if (0 < count(...)) {}
+	if (count(...) === 0) {}
 }
 
-function crashMbStrlen(): void
+function testSizeof(): void
 {
-	$fn = mb_strlen(...);
-	assertType('Closure(string, string|null=): int<0, max>', $fn);
+	$fn = sizeof(...);
+	assertType('Closure(array|Countable, int=): int', $fn);
 }
 
-function crashPregMatch(): void
+function testPregMatch(): void
 {
 	$fn = preg_match(...);
 	assertType('Closure(string, string, array<string>|null=, TFlags=, int=): (0|1|false)', $fn);
+
+	if (preg_match(...) < 1) {}
+	if (1 <= preg_match(...)) {}
 }
 
-function crashGettype(): void
+function testGettype(): void
 {
 	$fn = gettype(...);
 	assertType('Closure(mixed): string', $fn);
+
+	if (gettype(...) === 'string') {}
+	if (gettype(...) == 'string') {}
 }
 
-function crashGetClass(): void
+function testGetClass(): void
 {
 	$fn = get_class(...);
 	assertType('Closure(object=): class-string', $fn);
+
+	if (get_class(...) == 'stdClass') {}
 }
 
-function crashGetDebugType(): void
+function testGetDebugType(): void
 {
 	$fn = get_debug_type(...);
 	assertType('Closure(mixed): string', $fn);
+
+	if (get_debug_type(...) == 'string') {}
 }
 
-function crashGetParentClass(): void
+function testGetParentClass(): void
 {
 	$fn = get_parent_class(...);
 	assertType('Closure(object|string=): (class-string|false)', $fn);
+
+	if (get_parent_class(...) === 'stdClass') {}
 }
 
-function crashTrim(): void
+function testTrim(): void
 {
 	$fn = trim(...);
 	assertType('Closure(string, string=): string', $fn);
+
+	if (trim(...) !== '') {}
 }
 
-function crashLtrim(): void
+function testLtrim(): void
 {
 	$fn = ltrim(...);
 	assertType('Closure(string, string=): string', $fn);
+
+	if (ltrim(...) !== '') {}
 }
 
-function crashRtrim(): void
+function testRtrim(): void
 {
 	$fn = rtrim(...);
 	assertType('Closure(string, string=): string', $fn);
+
+	if (rtrim(...) !== '') {}
 }
 
-function crashArrayKeys(): void
+/**
+ * @param list<string> $list
+ */
+function testArrayKeysInForeach(array $list): void
 {
+	foreach (array_keys(...) as $key) {
+	}
 	$fn = array_keys(...);
 	assertType('Closure(array, mixed=, bool=): list<int|string>', $fn);
 }
+
+/**
+ * @param list<string> $list
+ */
+function testCountInForLoop(array $list): void
+{
+	for ($i = 0; $i < count(...); $i++) {
+	}
+}