Report uninitialized property when inherited constructor doesn't promote it

When an intermediate class overrides the constructor without a matching
parameter for the promoted property, the ancestor walk now stops instead
of incorrectly assuming the property is initialized. Uses constructor
parameter matching as a heuristic to determine if parent::__construct
is likely called.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

src/Node/ClassPropertiesNode.php

@@ -135,17 +135,7 @@ public function getUninitializedProperties(
 			if (!$is->yes() && $classReflection->hasConstructor()) {
 				$constructorDeclaringClass = $classReflection->getConstructor()->getDeclaringClass();
 				if ($constructorDeclaringClass->getName() !== $classReflection->getName()) {
-					$ancestor = $constructorDeclaringClass;
-					while ($ancestor !== null) {
-						if (
-							$ancestor->hasNativeProperty($property->getName())
-							&& $ancestor->getNativeProperty($property->getName())->isPromoted()
-						) {
-							$is = TrinaryLogic::createYes();
-							break;
-						}
-						$ancestor = $ancestor->getParentClass();
-					}
+					$is = $this->isPropertyInitializedByConstructorChain($constructorDeclaringClass, $property->getName());
 				}
 			}
 			if (!$is->yes() && $classReflection->hasNativeProperty($property->getName())) {
@@ -435,4 +425,46 @@ public function getPropertyAssigns(): array
 		return $this->propertyAssigns;
 	}
 
+	private function isPropertyInitializedByConstructorChain(ClassReflection $constructorDeclaringClass, string $propertyName): TrinaryLogic
+	{
+		$ancestor = $constructorDeclaringClass;
+		do {
+			$ancestorConstructor = $ancestor->getNativeReflection()->getConstructor();
+			if ($ancestorConstructor !== null) {
+				foreach ($ancestorConstructor->getParameters() as $param) {
+					if ($param->getName() === $propertyName && $param->isPromoted()) {
+						return TrinaryLogic::createYes();
+					}
+				}
+			}
+
+			$parent = $ancestor->getParentClass();
+			if ($parent === null) {
+				break;
+			}
+
+			$hasOwnConstructor = $ancestor->hasConstructor()
+				&& $ancestor->getConstructor()->getDeclaringClass()->getName() === $ancestor->getName();
+
+			if ($hasOwnConstructor) {
+				$hasMatchingParam = false;
+				if ($ancestorConstructor !== null) {
+					foreach ($ancestorConstructor->getParameters() as $param) {
+						if ($param->getName() === $propertyName) {
+							$hasMatchingParam = true;
+							break;
+						}
+					}
+				}
+				if (!$hasMatchingParam) {
+					break;
+				}
+			}
+
+			$ancestor = $parent;
+		} while (true);
+
+		return TrinaryLogic::createNo();
+	}
+
 }

tests/PHPStan/Rules/Properties/UninitializedPropertyRuleTest.php

@@ -240,6 +240,10 @@ public function testBug13380(): void
 				'Class Bug13380\Baz has an uninitialized property $prop. Give it default value or assign it in the constructor.',
 				33,
 			],
+			[
+				'Class Bug13380\Baz3 has an uninitialized property $prop. Give it default value or assign it in the constructor.',
+				57,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Properties/data/bug-13380.php

@@ -37,3 +37,22 @@ public function __construct()
 		// Does not call parent::__construct, so $prop is uninitialized
 	}
 }
+
+class Foo3
+{
+	public function __construct(
+		protected string $prop,
+	){
+	}
+}
+
+class Bar3 extends Foo3
+{
+	public function __construct()
+	{
+	}
+}
+
+class Baz3 extends Bar3 {
+	public string $prop;
+}