Respect @phpstan-all-methods-impure, @phpstan-all-methods-pure, and method-level purity annotations on built-in classes

- In PhpClassReflectionExtension::createMethod(), the built-in class path
  (line 614 condition) determined hasSideEffects solely from signature map
  metadata, ignoring PHPDoc purity annotations from stubs
- Added checks for method-level @phpstan-pure/@phpstan-impure from
  $currentResolvedPhpDoc->isPure(), then class-level
  @phpstan-all-methods-pure/@phpstan-all-methods-impure from
  $declaringClass->getResolvedPhpDoc()
- This mirrors the existing logic in createUserlandMethodReflection()
  (lines 908-932) which correctly handles these annotations
- Initialized $currentResolvedPhpDoc before the method signature loop to
  avoid undefined variable when the loop doesn't execute

Author: VincentLanglet

src/Reflection/Php/PhpClassReflectionExtension.php

@@ -618,6 +618,7 @@ private function createMethod(
 			$acceptsNamedArguments = true;
 			$selfOutType = null;
 			$phpDocComment = null;
+			$currentResolvedPhpDoc = null;
 			$methodSignaturesResult = $this->signatureMapProvider->getMethodSignatures($declaringClassName, $methodReflection->getName(), $methodReflection);
 			foreach ($methodSignaturesResult as $signatureType => $methodSignatures) {
 				if ($methodSignatures === null) {
@@ -732,6 +733,22 @@ private function createMethod(
 			} else {
 				$hasSideEffects = TrinaryLogic::createMaybe();
 			}
+
+			$isPure = null;
+			if ($currentResolvedPhpDoc !== null) {
+				$isPure = $currentResolvedPhpDoc->isPure();
+			}
+			if ($isPure === null) {
+				$classResolvedPhpDoc = $declaringClass->getResolvedPhpDoc();
+				if ($classResolvedPhpDoc !== null && $classResolvedPhpDoc->areAllMethodsPure()) {
+					$isPure = true;
+				} elseif ($classResolvedPhpDoc !== null && $classResolvedPhpDoc->areAllMethodsImpure()) {
+					$isPure = false;
+				}
+			}
+			if ($isPure !== null) {
+				$hasSideEffects = TrinaryLogic::createFromBoolean(!$isPure);
+			}
 			return new NativeMethodReflection(
 				$this->reflectionProviderProvider->getReflectionProvider(),
 				$declaringClass,

tests/PHPStan/Rules/Comparison/Bug14534MethodImpureTest.php

@@ -0,0 +1,40 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Comparison;
+
+use PHPStan\Analyser\RicherScopeGetTypeHelper;
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use function array_merge;
+
+/**
+ * @extends RuleTestCase<StrictComparisonOfDifferentTypesRule>
+ */
+class Bug14534MethodImpureTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new StrictComparisonOfDifferentTypesRule(
+			self::getContainer()->getByType(RicherScopeGetTypeHelper::class),
+			new PossiblyImpureTipHelper(true),
+			true,
+			true,
+			true,
+		);
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-14534-method-impure.php'], []);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return array_merge(
+			parent::getAdditionalConfigFiles(),
+			[__DIR__ . '/bug-14534-method-impure.neon'],
+		);
+	}
+
+}

tests/PHPStan/Rules/Comparison/Bug14534Test.php

@@ -0,0 +1,40 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Comparison;
+
+use PHPStan\Analyser\RicherScopeGetTypeHelper;
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use function array_merge;
+
+/**
+ * @extends RuleTestCase<StrictComparisonOfDifferentTypesRule>
+ */
+class Bug14534Test extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new StrictComparisonOfDifferentTypesRule(
+			self::getContainer()->getByType(RicherScopeGetTypeHelper::class),
+			new PossiblyImpureTipHelper(true),
+			true,
+			true,
+			true,
+		);
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-14534.php'], []);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return array_merge(
+			parent::getAdditionalConfigFiles(),
+			[__DIR__ . '/bug-14534.neon'],
+		);
+	}
+
+}

tests/PHPStan/Rules/Comparison/bug-14534-method-impure.neon

@@ -0,0 +1,3 @@
+parameters:
+	stubFiles:
+		- data/bug-14534-method-impure.stub

tests/PHPStan/Rules/Comparison/bug-14534.neon

@@ -0,0 +1,3 @@
+parameters:
+	stubFiles:
+		- data/bug-14534.stub

tests/PHPStan/Rules/Comparison/data/bug-14534-method-impure.php

@@ -0,0 +1,27 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14534MethodImpure;
+
+function sayStoreCas(string $key): void
+{
+	$memcached = new \Memcached();
+
+	do {
+		$extendedReturn = $memcached->get($key, null, \Memcached::GET_EXTENDED);
+
+		if ($memcached->getResultCode() !== \Memcached::RES_SUCCESS) {
+			return;
+		}
+
+		if (!is_array($extendedReturn) || !isset($extendedReturn['value']) || !isset($extendedReturn['cas'])) {
+			return;
+		}
+
+		$data = $extendedReturn['value'];
+		$cas = $extendedReturn['cas'];
+		\assert(is_float($cas));
+
+		$memcached->cas($cas, $key, $data);
+
+	} while ($memcached->getResultCode() !== \Memcached::RES_SUCCESS);
+}

tests/PHPStan/Rules/Comparison/data/bug-14534-method-impure.stub

@@ -0,0 +1,8 @@
+<?php
+
+class Memcached {
+	/**
+	 * @phpstan-impure
+	 */
+	public function getResultCode(): int {}
+}

tests/PHPStan/Rules/Comparison/data/bug-14534.php

@@ -0,0 +1,27 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14534;
+
+function sayStoreCas(string $key): void
+{
+	$memcached = new \Memcached();
+
+	do {
+		$extendedReturn = $memcached->get($key, null, \Memcached::GET_EXTENDED);
+
+		if ($memcached->getResultCode() !== \Memcached::RES_SUCCESS) {
+			return;
+		}
+
+		if (!is_array($extendedReturn) || !isset($extendedReturn['value']) || !isset($extendedReturn['cas'])) {
+			return;
+		}
+
+		$data = $extendedReturn['value'];
+		$cas = $extendedReturn['cas'];
+		\assert(is_float($cas));
+
+		$memcached->cas($cas, $key, $data);
+
+	} while ($memcached->getResultCode() !== \Memcached::RES_SUCCESS);
+}

tests/PHPStan/Rules/Comparison/data/bug-14534.stub

@@ -0,0 +1,6 @@
+<?php
+
+/**
+ * @phpstan-all-methods-impure
+ */
+class Memcached {}

tests/PHPStan/Rules/Pure/Bug14534AllPureBuiltinTest.php

@@ -0,0 +1,33 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Pure;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use function array_merge;
+
+/**
+ * @extends RuleTestCase<PureFunctionRule>
+ */
+class Bug14534AllPureBuiltinTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new PureFunctionRule(new FunctionPurityCheck());
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-14534-all-pure-builtin.php'], []);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return array_merge(
+			parent::getAdditionalConfigFiles(),
+			[__DIR__ . '/bug-14534-all-pure-builtin.neon'],
+		);
+	}
+
+}