Added tests

Author: staabm

tests/PHPStan/Rules/Comparison/IfConstantConditionRuleTest.php

@@ -194,4 +194,11 @@ public function testBug13384b(): void
 		]);
 	}
 
+	public function testBug7699(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-7699.php'], []);
+	}
+
+
 }

tests/PHPStan/Rules/Comparison/data/bug-7699.php

@@ -0,0 +1,10 @@
+<?php declare(strict_types=1);
+
+namespace Bug7699;
+
+$selections = isset($_GET['x']) ? explode(',', $_GET['x']) : [];
+while ($selections && $id = array_shift($selections)) {
+	if ($selections) {
+		var_dump('x');
+	}
+}

tests/PHPStan/Rules/Variables/IssetRuleTest.php

@@ -506,4 +506,12 @@ public function testBug10640(): void
 		$this->analyse([__DIR__ . '/../../Analyser/nsrt/bug-10640.php'], []);
 	}
 
+	public function testBug9503(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+
+		$this->analyse([__DIR__ . '/data/bug-9503.php'], []);
+	}
+
+
 }

tests/PHPStan/Rules/Variables/data/bug-9503.php

@@ -0,0 +1,19 @@
+<?php declare(strict_types=1);
+
+namespace Bug9503;
+
+class HelloWorld
+{
+	public function sayHello(string $str): bool
+	{
+		if (preg_match('~x(a)?(b)?~', $str, $matches) > 0) {
+			if (isset($matches[2]) && preg_match('~x2(a)?(b)?~', $matches[2], $matches) > 0) {
+				if (isset($matches[2])) {
+					return true;
+				}
+			}
+		}
+
+		return false;
+	}
+}