Feedback

Author: VincentLanglet

src/Type/Constant/ConstantArrayType.php

@@ -823,7 +823,7 @@ public function unsetOffset(Type $offsetType): Type
 	 * So the nextAutoIndexes won't change, and the array might still be a list even with PHPStan definition.
 	 *
 	 * @param list<ConstantIntegerType|ConstantStringType> $newKeyTypes
-	 * @param int[] 									   $newOptionalKeys
+	 * @param int[] $newOptionalKeys
 	 */
 	private static function isListAfterUnset(array $newKeyTypes, array $newOptionalKeys, TrinaryLogic $arrayIsList, bool $unsetOptionalKey): TrinaryLogic
 	{

tests/PHPStan/Analyser/nsrt/bug-14177.php

@@ -91,7 +91,7 @@ public function testUnset1OnList(array $b): void
 	{
 		assertType('true', array_is_list($b));
 		unset($b[1]);
-		assertType('false', array_is_list($b)); // Could be true
+		assertType('false', array_is_list($b));
 		$b[] = 'foo';
 		assertType('false', array_is_list($b));
 	}
@@ -105,7 +105,7 @@ public function testUnset2OnList(array $b): void
 		unset($b[2]);
 		assertType('bool', array_is_list($b));
 		$b[] = 'foo';
-		assertType('bool', array_is_list($b)); // Could be false
+		assertType('bool', array_is_list($b));
 	}
 
 	/**
@@ -115,9 +115,9 @@ public function testUnset3OnList(array $b): void
 	{
 		assertType('true', array_is_list($b));
 		unset($b[3]);
-		assertType('bool', array_is_list($b)); // Could be true
+		assertType('bool', array_is_list($b));
 		$b[] = 'foo';
-		assertType('bool', array_is_list($b)); // Could be false
+		assertType('bool', array_is_list($b));
 	}
 
 	/**
@@ -165,7 +165,7 @@ public function testUnset3OnArray(array $b): void
 		unset($b[3]);
 		assertType('bool', array_is_list($b));
 		$b[] = 'foo';
-		assertType('bool', array_is_list($b)); // Could be false
+		assertType('bool', array_is_list($b));
 	}
 
 	/**