Fix phpstan/phpstan#14019: Assignment in a key of array destructuring is ignored (#5164)

Co-authored-by: ondrejmirtes <104888+ondrejmirtes@users.noreply.github.com>
Co-authored-by: Markus Staab <markus.staab@redaxo.de>

Author: 3 people

src/Analyser/ExprHandler/AssignHandler.php

@@ -688,7 +688,7 @@ public function processAssignVar(
 					$throwPoints = array_merge($throwPoints, $keyResult->getThrowPoints());
 					$impurePoints = array_merge($impurePoints, $keyResult->getImpurePoints());
 					$isAlwaysTerminating = $isAlwaysTerminating || $keyResult->isAlwaysTerminating();
-					// no need for $keyResult->getScope()
+					$scope = $keyResult->getScope();
 				}
 
 				if ($arrayItem->key === null) {

tests/PHPStan/Analyser/nsrt/bug-14019.php

@@ -0,0 +1,10 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14019;
+
+use function PHPStan\Testing\assertType;
+
+[($a = 'foo') => $b] = ['foo' => 1];
+
+assertType("'foo'", $a);
+assertType('1', $b);

tests/PHPStan/Rules/Variables/DefinedVariableRuleTest.php

@@ -1393,6 +1393,16 @@ public function testBug6830(): void
 		$this->analyse([__DIR__ . '/data/bug-6830.php'], []);
 	}
 
+	public function testBug14019(): void
+	{
+		$this->cliArgumentsVariablesRegistered = true;
+		$this->polluteScopeWithLoopInitialAssignments = false;
+		$this->checkMaybeUndefinedVariables = true;
+		$this->polluteScopeWithAlwaysIterableForeach = true;
+
+		$this->analyse([__DIR__ . '/../../Analyser/nsrt/bug-14019.php'], []);
+	}
+
 	public function testBug14117(): void
 	{
 		$this->cliArgumentsVariablesRegistered = true;