add test for final and finalByKeyword() method

Author: samsonasik

tests/PHPStan/Reflection/ClassReflectionTest.php

@@ -34,6 +34,7 @@
 use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\TestCase;
 use ReflectionClass;
+use SomeNamespace\ClassWithConstants;
 use WrongClassConstantFile\SecuredRouter;
 use function array_map;
 use function array_values;
@@ -191,6 +192,19 @@ public function testDeprecatedConstantFromAnotherFile(): void
 		$this->assertTrue($constant->isDeprecated()->yes());
 	}
 
+	public function testFinalConstant(): void
+	{
+		$reflectionProvider = self::createReflectionProvider();
+		$reflection = $reflectionProvider->getClass(ClassWithConstants::class);
+		$constant = $reflection->getConstant('FINAL_FROM_DOCBLOCK');
+		$this->assertTrue($constant->isFinal());
+		$this->assertFalse($constant->isFinalByKeyword());
+
+		$constant = $reflection->getConstant('NATIVE_FINAL');
+		$this->assertTrue($constant->isFinal());
+		$this->assertTrue($constant->isFinalByKeyword());
+	}
+
 	/**
 	 * @param class-string $className
 	 * @param array<class-string, class-string> $expected

tests/PHPStan/Reflection/data/ClassWithConstants.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace SomeNamespace;
+
+class ClassWithConstants
+{
+    /**
+     * @final
+     */
+    public const FINAL_FROM_DOCBLOCK = 'final from docblock';
+
+    public final const NATIVE_FINAL = 'native final';
+}