Merge branch 2.1.x into 2.2.x

Author: phpstan-bot

src/Analyser/MutatingScope.php

@@ -3243,6 +3243,9 @@ public function filterBySpecifiedTypes(SpecifiedTypes $specifiedTypes): self
 
 				// Pass 2: Supertype match. Only runs when Pass 1 found no exact match for this expression.
 				foreach ($conditionalExpressions as $conditionalExpression) {
+					if ($conditionalExpression->getTypeHolder()->getCertainty()->no()) {
+						continue;
+					}
 					foreach ($conditionalExpression->getConditionExpressionTypeHolders() as $holderExprString => $conditionalTypeHolder) {
 						if (
 							!array_key_exists($holderExprString, $specifiedExpressions)

tests/PHPStan/Rules/Variables/NullCoalesceRuleTest.php

@@ -387,6 +387,11 @@ public function testBug4846(): void
 		]);
 	}
 
+	public function testBug14458(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-14458.php'], []);
+	}
+
 	public function testBug14393(): void
 	{
 		$this->analyse([__DIR__ . '/data/bug-14393.php'], [

tests/PHPStan/Rules/Variables/data/bug-14458.php

@@ -0,0 +1,50 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14458;
+
+use DateTime;
+
+class Foo
+{
+
+	/**
+	 * @param array<mixed> $payload
+	 * @return array<mixed>
+	 */
+	public function doFoo(array $payload): array
+	{
+		if ($payload['a'] !== 'b') {
+			throw new \Exception();
+		}
+
+		if (isset($payload['c'])) {
+			$c = array_values(array_map(static fn (array $cd) => $cd[0], $payload['c']));
+		}
+
+		$convertedPriceWithVat = null;
+		if (array_key_exists('cpwv', $payload)) {
+			$convertedAmount = (float) $payload['cpwv']['awv'];
+
+		}
+
+		return [
+			$payload['cf'],
+			$payload['n'],
+			$payload['d'] ?? null,
+			$payload['mb'] ?? null,
+			$payload['cr'],
+			new DateTime($payload['p']),
+			$payload['pn'],
+			$payload['pd'] ?? null,
+			$payload['piu'] ?? null,
+			$convertedPriceWithVat,
+			$payload['vi'],
+			$payload['pi'],
+			$payload['user']['name'] ?? null,
+			$payload['user']['phone'] ?? null,
+			$payload['ac'] ?? null,
+			$c ?? null,
+		];
+	}
+
+}