Rework

Author: VincentLanglet

src/Type/ArrayType.php

@@ -54,7 +54,7 @@ public function __construct(Type $keyType, private Type $itemType)
 			$keyType = new MixedType();
 		}
 		if ($keyType instanceof StrictMixedType && !$keyType instanceof TemplateStrictMixedType) {
-			$keyType = new BenevolentUnionType([new IntegerType(), new StringType()]);
+			$keyType = new UnionType([new StringType(), new IntegerType()]);
 		}
 
 		$this->keyType = $keyType;

src/Type/Generic/TemplateTypeTrait.php

@@ -6,7 +6,6 @@
 use PHPStan\PhpDocParser\Ast\Type\TypeNode;
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\AcceptsResult;
-use PHPStan\Type\BenevolentUnionType;
 use PHPStan\Type\ErrorType;
 use PHPStan\Type\IntersectionType;
 use PHPStan\Type\IsSuperTypeOfResult;
@@ -289,7 +288,7 @@ public function inferTemplateTypes(Type $receivedType): TemplateTypeMap
 			]))->union($map);
 		}
 
-		if ($receivedType instanceof BenevolentUnionType) {
+		if ($receivedType instanceof UnionType) {
 			$matchingTypes = [];
 			foreach ($receivedType->getTypes() as $innerType) {
 				if (!$resolvedBound->isSuperTypeOf($innerType)->yes()) {

tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php

@@ -937,7 +937,12 @@ public function testBug9732(): void
 		$this->checkExplicitMixed = true;
 		$this->checkImplicitMixed = true;
 
-		$this->analyse([__DIR__ . '/data/bug-9732.php'], []);
+		$this->analyse([__DIR__ . '/data/bug-9732.php'], [
+			[
+				'Parameter #1 $array of static method Bug9732\HelloWorld::stringifyKeys() expects array<string, mixed>, array<mixed> given.',
+				21,
+			],
+		]);
 	}
 
 	#[RequiresPhp('>= 8.5')]