Commit 388d60e
Address review: deduplicate test file and fix NeverType to be explicit
- Reuse tests/PHPStan/Analyser/nsrt/bug-2572.php in rule test instead of
duplicating the file in tests/PHPStan/Rules/Functions/data/
- Use explicit NeverType(true) for empty variadic params so the
UnresolvableTypeHelper doesn't treat it as unresolvable
- Add staabm's reproducer (value() with Closure|TValue union) as
additional test coverage
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent ae5b8bf commit 388d60e
4 files changed
Lines changed: 24 additions & 27 deletions
File tree
- src/Reflection
- tests/PHPStan
- Analyser/nsrt
- Rules/Functions
- data
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2693 | 2693 | | |
2694 | 2694 | | |
2695 | 2695 | | |
2696 | | - | |
| 2696 | + | |
2697 | 2697 | | |
2698 | 2698 | | |
2699 | 2699 | | |
| |||
This file was deleted.
0 commit comments