Cheap checks first

staabm · staabm · commit 3b92ce19477b · 2026-02-12T14:13:05.000+01:00
diff --git a/src/Rules/Classes/LocalTypeAliasesCheck.php b/src/Rules/Classes/LocalTypeAliasesCheck.php
@@ -335,8 +335,8 @@ private function isAliasNameValid(string $aliasName, ?NameScope $nameScope): boo
 		}
 
 		$aliasNameResolvedType = $this->typeNodeResolver->resolve(new IdentifierTypeNode($aliasName), $nameScope->bypassTypeAliases());
-		return ($aliasNameResolvedType->isObject()->yes() && !in_array($aliasName, ['self', 'parent'], true))
-			|| $aliasNameResolvedType instanceof TemplateType; // aliases take precedence over type parameters, this is reported by other rules using TemplateTypeCheck
+		return $aliasNameResolvedType instanceof TemplateType || // aliases take precedence over type parameters, this is reported by other rules using TemplateTypeCheck
+			($aliasNameResolvedType->isObject()->yes() && !in_array($aliasName, ['self', 'parent'], true));
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -335,8 +335,8 @@ private function isAliasNameValid(string $aliasName, ?NameScope $nameScope): boo`
`335`	`335`	`}`
`336`	`336`
`337`	`337`	`$aliasNameResolvedType = $this->typeNodeResolver->resolve(new IdentifierTypeNode($aliasName), $nameScope->bypassTypeAliases());`
`338`		`- return ($aliasNameResolvedType->isObject()->yes() && !in_array($aliasName, ['self', 'parent'], true))`
`339`		`- \|\| $aliasNameResolvedType instanceof TemplateType; // aliases take precedence over type parameters, this is reported by other rules using TemplateTypeCheck`
	`338`	`+ return $aliasNameResolvedType instanceof TemplateType \|\| // aliases take precedence over type parameters, this is reported by other rules using TemplateTypeCheck`
	`339`	`+ ($aliasNameResolvedType->isObject()->yes() && !in_array($aliasName, ['self', 'parent'], true));`
`340`	`340`	`}`
`341`	`341`
`342`	`342`	`/**`