Use isFinalByKeyword instead of isFinal

janedbal · janedbal · commit 4538d2f237c9 · 2026-03-16T16:47:39.000+01:00
@Final is just a PHPDoc convention with no runtime enforcement, so a child class can still extend and override property visibility.
diff --git a/src/Type/Php/ArrayColumnHelper.php b/src/Type/Php/ArrayColumnHelper.php
@@ -159,7 +159,7 @@ private function getOffsetOrProperty(Type $type, Type $offsetOrProperty, Scope $
 							return [new MixedType(), TrinaryLogic::createMaybe()];
 						}
 
-						if (!$classReflection->isFinal()) {
+						if (!$classReflection->isFinalByKeyword()) {
 							if ($property->isPrivate()) {
 								return [new MixedType(), TrinaryLogic::createMaybe()];
 							}

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ private function getOffsetOrProperty(Type $type, Type $offsetOrProperty, Scope $`
`159`	`159`	`return [new MixedType(), TrinaryLogic::createMaybe()];`
`160`	`160`	`}`
`161`	`161`
`162`		`- if (!$classReflection->isFinal()) {`
	`162`	`+ if (!$classReflection->isFinalByKeyword()) {`
`163`	`163`	`if ($property->isPrivate()) {`
`164`	`164`	`return [new MixedType(), TrinaryLogic::createMaybe()];`
`165`	`165`	`}`