Rework tests

Author: VincentLanglet

tests/PHPStan/Analyser/nsrt/bug-6799.php

@@ -4,6 +4,22 @@
 
 use function PHPStan\Testing\assertType;
 
+/**
+ * @param array<int> $items
+ */
+function functionProcessInts(array &$items): void
+{
+	$items = [1, 2];
+}
+
+/**
+ * @param array<string> $items
+ */
+function functionProcessStrings(array &$items): void
+{
+	$items = ['a', 'b'];
+}
+
 class HelloWorld
 {
 	/**
@@ -53,41 +69,48 @@ protected function testParamOut(): void
 	}
 
 	/**
-	 * @param array<mixed> $items
-	 * @param-out list<string> $items
+	 * @param array<int> $items
+	 */
+	protected function processInts(array &$items): void
+	{
+		$items = [1, 2];
+	}
+
+	/**
+	 * @param array<string> $items
 	 */
-	protected function processWithParamOutStrings(array &$items): void
+	protected function processStrings(array &$items): void
 	{
 		$items = ['a', 'b'];
 	}
 
 	/**
-	 * @param 'processWithParamOut'|'processWithParamOutStrings' $method
+	 * @param 'Bug6799\functionProcessInts'|'Bug6799\functionProcessStrings' $function
 	 */
-	protected function testUnionStringCallbacks(string $method): void
+	protected function testUnionStringCallbacks(string $function): void
 	{
 		$items = [];
-		call_user_func_array([$this, $method], [&$items]);
-		assertType('list<int|string>', $items);
+		call_user_func_array($function, [&$items]);
+		assertType('mixed', $items); // Could be array<int>|array<string>
 	}
 
 	/**
-	 * @param array{$this, 'processWithParamOut'}|array{$this, 'processWithParamOutStrings'} $callback
+	 * @param array{$this, 'processInts'}|array{$this, 'processStrings'} $callback
 	 */
 	protected function testUnionArrayCallbacks(array $callback): void
 	{
 		$items = [];
 		call_user_func_array($callback, [&$items]);
-		assertType('list<int|string>', $items);
+		assertType('mixed', $items); // Could be array<int>|array<string>
 	}
 
 	/**
-	 * @param 'processWithParamOut'|array{$this, 'processWithParamOutStrings'} $callback
+	 * @param 'Bug6799\functionProcessInts'|array{$this, 'processStrings'} $callback
 	 */
 	protected function testMixedUnionCallback($callback): void
 	{
 		$items = [];
 		call_user_func_array($callback, [&$items]);
-		assertType('array{}', $items);
+		assertType('mixed', $items); // Could be array<int>|array<string>
 	}
 }