Reorder equals() to do cheap string comparison before expensive type comparison

github-actions[bot] · staabm · claude · ondrejmirtes · commit 486393ae0d0c · 2026-02-16T11:12:21.000+01:00
Co-authored-by: Markus Staab &lt;markus.staab@redaxo.de&gt;
Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/Type/ClassConstantAccessType.php b/src/Type/ClassConstantAccessType.php
@@ -35,8 +35,8 @@ public function getReferencedTemplateTypes(TemplateTypeVariance $positionVarianc
 	public function equals(Type $type): bool
 	{
 		return $type instanceof self
-			&& $this->type->equals($type->type)
-			&& $this->constantName === $type->constantName;
+			&& $this->constantName === $type->constantName
+			&& $this->type->equals($type->type);
 	}
 
 	public function describe(VerbosityLevel $level): string

Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,8 @@ public function getReferencedTemplateTypes(TemplateTypeVariance $positionVarianc`
`35`	`35`	`public function equals(Type $type): bool`
`36`	`36`	`{`
`37`	`37`	`return $type instanceof self`
`38`		`- && $this->type->equals($type->type)`
`39`		`- && $this->constantName === $type->constantName;`
	`38`	`+ && $this->constantName === $type->constantName`
	`39`	`+ && $this->type->equals($type->type);`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`public function describe(VerbosityLevel $level): string`