Add some comments

Author: VincentLanglet

tests/PHPStan/Analyser/nsrt/bug-6799.php

@@ -51,7 +51,7 @@ function testByRefInArray(): void
 	assertType('array{}', $a);
 
 	$b = [&$a];
-	assertType('mixed', $a);
+	assertType('mixed', $a); // Could stay array{}
 
 	foo($b);
 	assertType('mixed', $a);
@@ -63,7 +63,10 @@ function testByRefInArrayWithKey(): void
 	assertType("'hello'", $a);
 
 	$b = ['key' => &$a];
-	assertType('mixed', $a);
+	assertType('mixed', $a); // Could stay 'hello'
+
+	$b['key'] = 42;
+	assertType('mixed', $a); // Could be 42
 }
 
 function testMultipleByRefInArray(): void
@@ -72,6 +75,13 @@ function testMultipleByRefInArray(): void
 	$c = 'test';
 
 	$b = [&$a, 'normal', &$c];
-	assertType('mixed', $a);
-	assertType('mixed', $c);
+	assertType('mixed', $a); // Could stay 1
+	assertType('mixed', $c); // Could stay 'test'
+
+	$b[0] = 2;
+	$b[1] = 'foo';
+	$b[2] = 'bar';
+
+	assertType('mixed', $a); // Could be 2
+	assertType('mixed', $c); // Could be 'bar'
 }

tests/PHPStan/Analyser/nsrt/bug-6799c.php

@@ -6,13 +6,14 @@
 
 // https://3v4l.org/g5UjS
 
+$x = null;
+assertType('null', $x);
 $a = [&$x];
+assertType('mixed', $x); // Could stay null
+
 function doFoo(array &$arr) {
 	$arr[0] = 'string';
 }
 
-var_dump($x);
-assertType('mixed', $x);
 doFoo($a);
-var_dump($x);
-assertType('mixed', $x); // could be string
+assertType('mixed', $x);

tests/PHPStan/Rules/Variables/DefinedVariableRuleTest.php

@@ -1437,12 +1437,7 @@ public function testBug6799c(): void
 		$this->checkMaybeUndefinedVariables = true;
 		$this->polluteScopeWithAlwaysIterableForeach = true;
 
-		$this->analyse([__DIR__ . '/../../Analyser/nsrt/bug-6799c.php'], [
-			[
-				'Variable $x might not be defined.',
-				9,
-			],
-		]);
+		$this->analyse([__DIR__ . '/../../Analyser/nsrt/bug-6799c.php'], []);
 	}
 
 }