Skip to content

Commit 4ecb986

Browse files
VincentLangletVincentLanglet
committed
Remove BCMath\Number
1 parent 518cb27 commit 4ecb986

File tree

5 files changed

+11
-49
lines changed

5 files changed

+11
-49
lines changed

‎tests/PHPStan/Analyser/nsrt/bug-14136.php‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,10 @@
2121

2222
assertType('string', strval($xml));
2323
assertType('non-empty-string&numeric-string', strval(gmp_init(42)));
24-
assertType('non-empty-string&numeric-string', strval(new \BCMath\Number(99)));
2524
assertType('string', (string) ($xml));
2625
assertType('non-empty-string&numeric-string', (string) (gmp_init(42)));
27-
assertType('non-empty-string&numeric-string', (string) new \BCMath\Number(99));
2826

2927
assertType('bool', boolval($xml));
3028
assertType('bool', boolval(gmp_init(0)));
31-
assertType('bool', boolval(new \BCMath\Number(0)));
3229
assertType('bool', (bool) ($xml));
3330
assertType('bool', (bool) (gmp_init(0)));
34-
assertType('bool', (bool) (new \BCMath\Number(0)));

‎tests/PHPStan/Rules/Cast/InvalidCastRuleTest.php‎

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -74,16 +74,7 @@ public function testRuleWithNullsafeVariant(): void
7474

7575
public function testBug14136(): void
7676
{
77-
$this->analyse([__DIR__ . '/data/bug-14136.php'], [
78-
[
79-
'Cannot cast BcMath\Number to int.',
80-
15,
81-
],
82-
[
83-
'Cannot cast BcMath\Number to float.',
84-
22,
85-
],
86-
]);
77+
$this->analyse([__DIR__ . '/data/bug-14136.php'], []);
8778
}
8879

8980
public function testCastObjectToString(): void

‎tests/PHPStan/Rules/Cast/data/bug-14136.php‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,28 +9,20 @@
99
$xml = simplexml_load_string($xml);
1010
var_dump(intval($xml));
1111
var_dump(intval(gmp_init(42)));
12-
var_dump(intval (new \BCMath\Number(99))); // Invalid
1312
var_dump((int) ($xml));
1413
var_dump((int)(gmp_init(42)));
15-
var_dump((int) new \BCMath\Number(99)); // Invalid
1614

1715
var_dump(floatval ($xml));
1816
var_dump(floatval(gmp_init(42)));
19-
var_dump(floatval(new \BCMath\Number(99))); // Invalid
2017
var_dump((float) ($xml));
2118
var_dump((float)(gmp_init(42)));
22-
var_dump((float) new \BCMath\Number(99)); // Invalid
2319

2420
var_dump(strval($xml));
2521
var_dump(strval(gmp_init(42)));
26-
var_dump(strval(new \BCMath\Number(99)));
2722
var_dump((string) ($xml));
2823
var_dump((string)(gmp_init(42)));
29-
var_dump((string) new \BCMath\Number(99));
3024

3125
var_dump(boolval($xml));
3226
var_dump(boolval(gmp_init(42)));
33-
var_dump(boolval (new \BCMath\Number(99)));
3427
var_dump((bool) ($xml));
3528
var_dump((bool) (gmp_init(42)));
36-
var_dump((bool) (new \BCMath\Number(42)));

‎tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php‎

Lines changed: 10 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -2481,39 +2481,39 @@ public function testBug6560(string $fileName): void
24812481

24822482
$this->analyse([__DIR__ . '/data/' . $fileName], [
24832483
[
2484-
sprintf('Parameter #1 %s of function strval expects bool|float|int|resource|string|null, array given.', $varName),
2484+
sprintf('Parameter #1 %s of function strval expects bool|float|GMP|int|resource|string|null, array given.', $varName),
24852485
23,
24862486
],
24872487
[
2488-
sprintf('Parameter #1 %s of function strval expects bool|float|int|resource|string|null, stdClass given.', $varName),
2488+
sprintf('Parameter #1 %s of function strval expects bool|float|GMP|int|resource|string|null, stdClass given.', $varName),
24892489
77,
24902490
],
24912491
[
2492-
sprintf('Parameter #1 %s of function intval expects array|bool|float|int|resource|string|null, stdClass given.', $varName),
2492+
sprintf('Parameter #1 %s of function intval expects array|bool|float|GMP|int|resource|SimpleXMLElement|string|null, stdClass given.', $varName),
24932493
80,
24942494
],
24952495
[
2496-
sprintf('Parameter #1 %s of function floatval expects array|bool|float|int|resource|string|null, stdClass given.', $varName),
2496+
sprintf('Parameter #1 %s of function floatval expects array|bool|float|GMP|int|resource|SimpleXMLElement|string|null, stdClass given.', $varName),
24972497
83,
24982498
],
24992499
[
2500-
sprintf('Parameter #1 %s of function intval expects array|bool|float|int|resource|string|null, %s@anonymous/tests/PHPStan/Rules/Functions/data/' . $fileName . ':13 given.', $varName, $stringableName),
2500+
sprintf('Parameter #1 %s of function intval expects array|bool|float|GMP|int|resource|SimpleXMLElement|string|null, %s@anonymous/tests/PHPStan/Rules/Functions/data/' . $fileName . ':13 given.', $varName, $stringableName),
25012501
89,
25022502
],
25032503
[
2504-
sprintf('Parameter #1 %s of function floatval expects array|bool|float|int|resource|string|null, %s@anonymous/tests/PHPStan/Rules/Functions/data/' . $fileName . ':13 given.', $varName, $stringableName),
2504+
sprintf('Parameter #1 %s of function floatval expects array|bool|float|GMP|int|resource|SimpleXMLElement|string|null, %s@anonymous/tests/PHPStan/Rules/Functions/data/' . $fileName . ':13 given.', $varName, $stringableName),
25052505
92,
25062506
],
25072507
[
2508-
sprintf('Parameter #1 %s of function strval expects bool|float|int|resource|string|null, mixed given.', $varName),
2508+
sprintf('Parameter #1 %s of function strval expects bool|float|GMP|int|resource|string|null, mixed given.', $varName),
25092509
95,
25102510
],
25112511
[
2512-
sprintf('Parameter #1 %s of function intval expects array|bool|float|int|resource|string|null, mixed given.', $varName),
2512+
sprintf('Parameter #1 %s of function intval expects array|bool|float|GMP|int|resource|SimpleXMLElement|string|null, mixed given.', $varName),
25132513
98,
25142514
],
25152515
[
2516-
sprintf('Parameter #1 %s of function floatval expects array|bool|float|int|resource|string|null, mixed given.', $varName),
2516+
sprintf('Parameter #1 %s of function floatval expects array|bool|float|GMP|int|resource|SimpleXMLElement|string|null, mixed given.', $varName),
25172517
101,
25182518
],
25192519
]);
@@ -2680,16 +2680,7 @@ public function testBug9652(): void
26802680

26812681
public function testBug14136(): void
26822682
{
2683-
$this->analyse([__DIR__ . '/data/bug-14136.php'], [
2684-
[
2685-
'Parameter #1 $value of function intval expects array|bool|float|GMP|int|resource|SimpleXMLElement|string|null, BcMath\Number given.',
2686-
12,
2687-
],
2688-
[
2689-
'Parameter #1 $value of function floatval expects array|bool|float|GMP|int|resource|SimpleXMLElement|string|null, BcMath\Number given.',
2690-
19,
2691-
],
2692-
]);
2683+
$this->analyse([__DIR__ . '/data/bug-14136.php'], []);
26932684
}
26942685

26952686
#[RequiresPhp('>= 8.1')]

‎tests/PHPStan/Rules/Functions/data/bug-14136.php‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,28 +9,20 @@
99
$xml = simplexml_load_string($xml);
1010
var_dump(intval($xml));
1111
var_dump(intval(gmp_init(42)));
12-
var_dump(intval (new \BCMath\Number(99))); // Invalid
1312
var_dump((int) ($xml));
1413
var_dump((int)(gmp_init(42)));
15-
var_dump((int) new \BCMath\Number(99)); // Invalid
1614

1715
var_dump(floatval ($xml));
1816
var_dump(floatval(gmp_init(42)));
19-
var_dump(floatval(new \BCMath\Number(99))); // Invalid
2017
var_dump((float) ($xml));
2118
var_dump((float)(gmp_init(42)));
22-
var_dump((float) new \BCMath\Number(99)); // Invalid
2319

2420
var_dump(strval($xml));
2521
var_dump(strval(gmp_init(42)));
26-
var_dump(strval(new \BCMath\Number(99)));
2722
var_dump((string) ($xml));
2823
var_dump((string)(gmp_init(42)));
29-
var_dump((string) new \BCMath\Number(99));
3024

3125
var_dump(boolval($xml));
3226
var_dump(boolval(gmp_init(42)));
33-
var_dump(boolval (new \BCMath\Number(99)));
3427
var_dump((bool) ($xml));
3528
var_dump((bool) (gmp_init(42)));
36-
var_dump((bool) (new \BCMath\Number(42)));

0 commit comments

Comments
 (0)