test upper limit

Author: staabm

src/Command/ErrorFormatter/TableErrorFormatter.php

@@ -30,7 +30,7 @@
 final class TableErrorFormatter implements ErrorFormatter
 {
 
-	private const ERRORS_LIMIT = 1000;
+	public const ERRORS_LIMIT = 1000;
 	private const FORCE_SHOW_ALL_ERRORS = 'PHPSTAN_TABLE_ERROR_FORMATTER_FORCE_SHOW_ALL_ERRORS';
 
 	public function __construct(

tests/PHPStan/Command/ErrorFormatter/TableErrorFormatterTest.php

@@ -423,20 +423,25 @@ public static function dataErrorLimit(): iterable
 			yield [
 				'errorsBudget' => null,
 				'usedLevel' => '8',
-				'showAllErrors' => true,
-				'expected' => ' ------ -------------------------------
-  Line   Foo.php (in context of trait)
- ------ -------------------------------
-  12     Test
-  13     Test
-  14     Test
-  15     Test
- ------ -------------------------------
+				'showAllErrors' => false,
+				'expected' => '
 
+ [ERROR] Found 1000+ errors
 
- [ERROR] Found 4 errors
+',
+				'generateErrorsCount' => TableErrorFormatter::ERRORS_LIMIT + 5,
+			];
+
+			yield [
+				'errorsBudget' => null,
+				'usedLevel' => '8',
+				'showAllErrors' => true,
+				'expected' => '
+
+ [ERROR] Found 1005 errors
 
 ',
+				'generateErrorsCount' => TableErrorFormatter::ERRORS_LIMIT + 5,
 			];
 	}
 
@@ -446,6 +451,7 @@ public function testErrorLimit(
 		string $usedLevel,
 		bool $showAllErrors,
 		string $expected,
+		int $generateErrorsCount = 4,
 	): void
 	{
 		putenv('COLUMNS=200');
@@ -464,10 +470,11 @@ public function testErrorLimit(
 			$errorsBudget,
 		);
 		$errors = [];
-		$errors[] = new Error('Test', 'Foo.php (in context of trait)', 12, filePath: 'Foo.php', traitFilePath: 'Bar.php');
-		$errors[] = new Error('Test', 'Foo.php (in context of trait)', 13, filePath: 'Foo.php', traitFilePath: 'Bar.php');
-		$errors[] = new Error('Test', 'Foo.php (in context of trait)', 14, filePath: 'Foo.php', traitFilePath: 'Bar.php');
-		$errors[] = new Error('Test', 'Foo.php (in context of trait)', 15, filePath: 'Foo.php', traitFilePath: 'Bar.php');
+		$line = 12;
+		for ($i = 0; $i < $generateErrorsCount; $i++) {
+			$errors[] = new Error('Test', 'Foo.php (in context of trait)', $line, filePath: 'Foo.php', traitFilePath: 'Bar.php');
+			$line++;
+		}
 		$formatter->formatErrors(new AnalysisResult($errors, [], [], [], [], false, null, true, 0, false, []), $this->getOutput());
 
 		$this->assertStringContainsString($expected, $this->getOutputContent());