Simplify tests

Author: VincentLanglet

tests/PHPStan/Rules/DeadCode/UnreachableStatementRuleTest.php

@@ -380,19 +380,19 @@ public function testBug14328(): void
 		$this->analyse([__DIR__ . '/data/bug-14328.php'], [
 			[
 				'Unreachable statement - code above always terminates.',
-				25,
+				20,
 			],
 			[
 				'Unreachable statement - code above always terminates.',
-				31,
+				26,
 			],
 			[
 				'Unreachable statement - code above always terminates.',
-				37,
+				32,
 			],
 			[
 				'Unreachable statement - code above always terminates.',
-				43,
+				38,
 			],
 		]);
 	}

tests/PHPStan/Rules/DeadCode/data/bug-14328.php

@@ -9,36 +9,31 @@ public function returnThis(mixed $value): self {
 		return $this;
 	}
 
-	public static function staticReturnSelf(mixed $value): self {
+	public static function returnSelf(mixed $value): self {
 		return new self();
 	}
 }
 
-class Bar {
-	public static function doSomething(mixed $value): void {
-	}
-}
-
-function testMethodCall(): void {
+function testMethodCallChainedWithMethodCall(): void {
 	$callback = fn (): never => throw new \Exception();
 	$x = (new Foo())->returnThis($callback())->returnThis('x');
 	$y = 'this will never run';
 }
 
-function testStaticCall(): void {
+function testMethodCallChainedWithStaticCall(): void {
 	$callback = fn (): never => throw new \Exception();
-	Bar::doSomething($callback());
-	$b = 'this will never run';
+	$x = (new Foo())->returnThis($callback())::returnSelf('x');
+	$y = 'this will never run';
 }
 
 function testStaticCallChainedWithMethodCall(): void {
 	$callback = fn (): never => throw new \Exception();
-	$a = Foo::staticReturnSelf($callback())->returnThis('x');
+	$a = Foo::returnSelf($callback())->returnThis('x');
 	$b = 'this will never run either';
 }
 
 function testStaticCallChainedWithStaticCall(): void {
 	$callback = fn (): never => throw new \Exception();
-	$a = Foo::staticReturnSelf($callback())::staticReturnSelf('x');
+	$a = Foo::returnSelf($callback())::returnSelf('x');
 	$b = 'this will never run either';
 }