Revert AssignHandler changes for bug #14473

The fix for the false positive logicalOr.leftAlwaysTrue on repeated
builtin function calls does not require code changes to AssignHandler.

The root cause is that TypeSpecifier already returns empty SpecifiedTypes
for functions with hasSideEffects()->yes() (TypeSpecifier.php line 2246),
which prevents conditional expressions from being created in
AssignHandler. The proper fix is to mark mysqli_connect in the function
metadata, which is done in the next commit.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

src/Analyser/ExprHandler/AssignHandler.php

@@ -45,7 +45,6 @@
 use PHPStan\Node\PropertyAssignNode;
 use PHPStan\Node\VariableAssignNode;
 use PHPStan\Php\PhpVersion;
-use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\ShouldNotHappenException;
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\Accessory\AccessoryArrayListType;
@@ -85,7 +84,6 @@ final class AssignHandler implements ExprHandler
 	public function __construct(
 		private TypeSpecifier $typeSpecifier,
 		private PhpVersion $phpVersion,
-		private ReflectionProvider $reflectionProvider,
 	)
 	{
 	}
@@ -863,13 +861,10 @@ private function processSureTypesForConditionalExpressionsAfterAssign(Scope $sco
 				if ($expr->name === $variableName) {
 					continue;
 				}
-			} elseif ($expr instanceof FuncCall) {
-				if ($this->isBuiltinFunctionCallWithPossibleSideEffects($expr, $scope)) {
-					continue;
-				}
 			} elseif (
 				!$expr instanceof PropertyFetch
 				&& !$expr instanceof ArrayDimFetch
+				&& !$expr instanceof FuncCall
 			) {
 				continue;
 			}
@@ -905,13 +900,10 @@ private function processSureNotTypesForConditionalExpressionsAfterAssign(Scope $
 				if ($expr->name === $variableName) {
 					continue;
 				}
-			} elseif ($expr instanceof FuncCall) {
-				if ($this->isBuiltinFunctionCallWithPossibleSideEffects($expr, $scope)) {
-					continue;
-				}
 			} elseif (
 				!$expr instanceof PropertyFetch
 				&& !$expr instanceof ArrayDimFetch
+				&& !$expr instanceof FuncCall
 			) {
 				continue;
 			}
@@ -932,21 +924,6 @@ private function processSureNotTypesForConditionalExpressionsAfterAssign(Scope $
 		return $conditionalExpressions;
 	}
 
-	private function isBuiltinFunctionCallWithPossibleSideEffects(Expr $expr, Scope $scope): bool
-	{
-		if (!$expr instanceof FuncCall || !$expr->name instanceof Name) {
-			return false;
-		}
-
-		if (!$this->reflectionProvider->hasFunction($expr->name, $scope)) {
-			return false;
-		}
-
-		$functionReflection = $this->reflectionProvider->getFunction($expr->name, $scope);
-
-		return $functionReflection->isBuiltin() && !$functionReflection->hasSideEffects()->no();
-	}
-
 	/**
 	 * @param list<ArrayDimFetch> $dimFetchStack
 	 */