Fix: Only invalidate expressions for immediately-invoked callables, not later-invoked ones

The deferredInvalidateExpressions were being collected unconditionally
for all closures, regardless of whether the callable was marked with
@param-immediately-invoked-callable or @param-later-invoked-callable.
This caused property types to be incorrectly invalidated even for
later-invoked callables where the callback hasn't executed yet.

Gate deferredInvalidateExpressions behind callCallbackImmediately() and
update the bug-11417 test to assert that the later-invoked-callable case
correctly reports "If condition is always true" instead of just a comment.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

src/Analyser/NodeScopeResolver.php

@@ -3370,7 +3370,9 @@ public function processArgs(
 					$scope = $scope->restoreThis($restoreThisScope);
 				}
 
-				$deferredInvalidateExpressions[] = [$invalidateExpressions, $uses];
+				if ($this->callCallbackImmediately($parameter, $parameterType, $calleeReflection)) {
+					$deferredInvalidateExpressions[] = [$invalidateExpressions, $uses];
+				}
 			} elseif ($arg->value instanceof Expr\ArrowFunction) {
 				if (
 					$closureBindScope === null
@@ -3418,8 +3420,8 @@ public function processArgs(
 				if ($exprType->isCallable()->yes()) {
 					$acceptors = $exprType->getCallableParametersAcceptors($scope);
 					if (count($acceptors) === 1) {
-						$deferredInvalidateExpressions[] = [$acceptors[0]->getInvalidateExpressions(), $acceptors[0]->getUsedVariables()];
 						if ($this->callCallbackImmediately($parameter, $parameterType, $calleeReflection)) {
+							$deferredInvalidateExpressions[] = [$acceptors[0]->getInvalidateExpressions(), $acceptors[0]->getUsedVariables()];
 							$callableThrowPoints = array_map(static fn (SimpleThrowPoint $throwPoint) => $throwPoint->isExplicit() ? InternalThrowPoint::createExplicit($scope, $throwPoint->getType(), $arg->value, $throwPoint->canContainAnyThrowable()) : InternalThrowPoint::createImplicit($scope, $arg->value), $acceptors[0]->getThrowPoints());
 							if (!$this->implicitThrows) {
 								$callableThrowPoints = array_values(array_filter($callableThrowPoints, static fn (InternalThrowPoint $throwPoint) => $throwPoint->isExplicit()));

tests/PHPStan/Rules/Comparison/IfConstantConditionRuleTest.php

@@ -186,7 +186,13 @@ public function testBug8926(): void
 	public function testBug11417(): void
 	{
 		$this->treatPhpDocTypesAsCertain = true;
-		$this->analyse([__DIR__ . '/data/bug-11417.php'], []);
+		$this->analyse([__DIR__ . '/data/bug-11417.php'], [
+			[
+				'If condition is always true.',
+				66,
+				'Because the type is coming from a PHPDoc, you can turn off this check by setting <fg=cyan>treatPhpDocTypesAsCertain: false</> in your <fg=cyan>%configurationFile%</>.',
+			],
+		]);
 	}
 
 	public function testBug10903(): void

tests/PHPStan/Rules/Comparison/data/bug-11417.php

@@ -63,7 +63,7 @@ public function getConn(): string
 			$this->conn = "conn";
 		});
 
-		if (is_null($this->conn)) { // should be always true - later-invoked callable doesn't invalidate
+		if (is_null($this->conn)) {
 			throw new \Exception("conn failed");
 		}