Fix false positive abount allowed constants in parameters

Author: ondrejmirtes

src/Reflection/BetterReflection/BetterReflectionProvider.php

@@ -444,6 +444,7 @@ public function getConstant(Node\Name $nameNode, ?NamespaceAnswerer $namespaceAn
 				array_map(static fn (BetterReflectionAttribute $betterReflectionAttribute) => ReflectionAttributeFactory::create($betterReflectionAttribute), $constantReflection->getAttributes()),
 				InitializerExprContext::fromGlobalConstant($constantReflection),
 			),
+			$constantReflection->isInternal(),
 		);
 	}
 

src/Reflection/Constant/RuntimeConstantReflection.php

@@ -20,6 +20,7 @@ public function __construct(
 		private TrinaryLogic $isDeprecated,
 		private ?string $deprecatedDescription,
 		private array $attributes,
+		private bool $internal,
 	)
 	{
 	}
@@ -29,6 +30,16 @@ public function getName(): string
 		return $this->name;
 	}
 
+	public function describe(): string
+	{
+		return $this->name;
+	}
+
+	public function isBuiltin(): TrinaryLogic
+	{
+		return TrinaryLogic::createFromBoolean($this->internal);
+	}
+
 	public function getValueType(): Type
 	{
 		return $this->valueType;

src/Reflection/ConstantReflection.php

@@ -20,6 +20,10 @@ interface ConstantReflection
 
 	public function getName(): string;
 
+	public function describe(): string;
+
+	public function isBuiltin(): TrinaryLogic;
+
 	public function getValueType(): Type;
 
 	public function isDeprecated(): TrinaryLogic;

src/Reflection/Dummy/DummyClassConstantReflection.php

@@ -12,6 +12,7 @@
 use PHPStan\Type\MixedType;
 use PHPStan\Type\Type;
 use stdClass;
+use function sprintf;
 
 final class DummyClassConstantReflection implements ClassConstantReflection
 {
@@ -62,6 +63,16 @@ public function getName(): string
 		return $this->name;
 	}
 
+	public function describe(): string
+	{
+		return sprintf('%s::%s', $this->getDeclaringClass()->getDisplayName(), $this->name);
+	}
+
+	public function isBuiltin(): TrinaryLogic
+	{
+		return TrinaryLogic::createFromBoolean($this->getDeclaringClass()->isBuiltin());
+	}
+
 	public function getValueType(): Type
 	{
 		return new MixedType();

src/Reflection/ParameterAllowedConstants.php

@@ -47,15 +47,6 @@ public function getExclusiveGroups(): array
 		return $this->exclusiveGroups;
 	}
 
-	private function resolveConstantName(ConstantReflection $constant): string
-	{
-		if ($constant instanceof ClassConstantReflection) {
-			return $constant->getDeclaringClass()->getName() . '::' . $constant->getName();
-		}
-
-		return $constant->getName();
-	}
-
 	/**
 	 * @param list<ConstantReflection> $constants
 	 */
@@ -67,7 +58,11 @@ public function check(array $constants): AllowedConstantsResult
 		$names = [];
 
 		foreach ($constants as $constant) {
-			$name = $this->resolveConstantName($constant);
+			if ($constant->isBuiltin()->no()) {
+				continue;
+			}
+
+			$name = $constant->describe();
 			$names[] = $name;
 
 			if (in_array($name, $this->constants, true)) {

src/Reflection/RealClassClassConstantReflection.php

@@ -9,6 +9,7 @@
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypehintHelper;
+use function sprintf;
 
 final class RealClassClassConstantReflection implements ClassConstantReflection
 {
@@ -39,6 +40,16 @@ public function getName(): string
 		return $this->reflection->getName();
 	}
 
+	public function describe(): string
+	{
+		return sprintf('%s::%s', $this->declaringClass->getDisplayName(), $this->getName());
+	}
+
+	public function isBuiltin(): TrinaryLogic
+	{
+		return TrinaryLogic::createFromBoolean($this->declaringClass->isBuiltin());
+	}
+
 	public function getFileName(): ?string
 	{
 		return $this->declaringClass->getFileName();

src/Rules/FunctionCallParametersCheck.php

@@ -424,7 +424,7 @@ public function check(
 						foreach ($result->getDisallowedConstants() as $disallowedConstant) {
 							$errors[] = RuleErrorBuilder::message(sprintf(
 								$invalidConstantMessage,
-								$disallowedConstant->getName(),
+								$disallowedConstant->describe(),
 								lcfirst($this->describeParameter($parameter, $argumentName ?? $i + 1)),
 							))
 								->identifier('argument.invalidConstant')

src/Rules/RestrictedUsage/RewrittenDeclaringClassClassConstantReflection.php

@@ -8,6 +8,7 @@
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\Type;
+use function sprintf;
 
 final class RewrittenDeclaringClassClassConstantReflection implements ClassConstantReflection
 {
@@ -89,6 +90,16 @@ public function getName(): string
 		return $this->constantReflection->getName();
 	}
 
+	public function describe(): string
+	{
+		return sprintf('%s::%s', $this->getDeclaringClass()->getDisplayName(), $this->getName());
+	}
+
+	public function isBuiltin(): TrinaryLogic
+	{
+		return TrinaryLogic::createFromBoolean($this->getDeclaringClass()->isBuiltin());
+	}
+
 	public function getValueType(): Type
 	{
 		return $this->constantReflection->getValueType();

tests/PHPStan/Rules/Classes/InstantiationRuleTest.php

@@ -624,7 +624,7 @@ public function testConstantParameterCheckInstantiation(): void
 				12,
 			],
 			[
-				'Constant GREGORIAN is not allowed for parameter #2 $dateType of class IntlDateFormatter constructor.',
+				'Constant IntlDateFormatter::GREGORIAN is not allowed for parameter #2 $dateType of class IntlDateFormatter constructor.',
 				18,
 			],
 		]);

tests/PHPStan/Rules/Functions/data/constant-parameter-check.php

@@ -80,3 +80,18 @@
 
 // round: single-value parameter - correct
 round(1.5, 0, PHP_ROUND_HALF_UP);
+
+class Foo
+{
+	private const PASSWORD_ALGORITHM = PASSWORD_ARGON2ID;
+
+	// user-defined class constant wrapping a valid constant - should not report
+	public function hashPassword(string $password): string
+	{
+		return password_hash($password, self::PASSWORD_ALGORITHM);
+	}
+}
+
+// user-defined global constant wrapping a valid constant - should not report
+define('MY_JSON_FLAGS', JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES);
+json_encode([], MY_JSON_FLAGS);