Check inner union types before delegating to isSubTypeOf for LateResolvableType in UnionType::isSuperTypeOf() (#5645)

Co-authored-by: VincentLanglet <9052536+VincentLanglet@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Markus Staab <maggus.staab@googlemail.com>

Author: 4 people

src/Type/UnionType.php

@@ -268,7 +268,6 @@ public function isSuperTypeOf(Type $otherType): IsSuperTypeOfResult
 			($otherType instanceof self && !$otherType instanceof TemplateUnionType)
 			|| ($otherType instanceof IterableType && !$otherType instanceof TemplateIterableType)
 			|| $otherType instanceof NeverType
-			|| ($otherType instanceof LateResolvableType && $otherType instanceof CompoundType && !$otherType instanceof TemplateType)
 			|| $otherType instanceof IntegerRangeType
 		) {
 			return $otherType->isSubTypeOf($this);
@@ -284,7 +283,10 @@ public function isSuperTypeOf(Type $otherType): IsSuperTypeOfResult
 		}
 		$result = IsSuperTypeOfResult::createNo()->or(...$results);
 
-		if ($otherType instanceof TemplateUnionType) {
+		if (
+			$otherType instanceof TemplateUnionType
+			|| ($otherType instanceof LateResolvableType && $otherType instanceof CompoundType && !$otherType instanceof TemplateType)
+		) {
 			return $result->or($otherType->isSubTypeOf($this));
 		}
 

tests/PHPStan/Rules/Methods/MethodSignatureRuleTest.php

@@ -630,4 +630,12 @@ public function testBug14563Trait(): void
 		]);
 	}
 
+	#[RequiresPhp('>= 8.0.0')]
+	public function testBug10942(): void
+	{
+		$this->reportMaybes = true;
+		$this->reportStatic = true;
+		$this->analyse([__DIR__ . '/data/bug-10942.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Methods/data/bug-10942.php

@@ -0,0 +1,58 @@
+<?php // lint >= 8.0
+
+namespace Bug10942;
+
+class A
+{
+	/**
+	 * @param string|($operator is 'in' ? int : never) $sqlRight
+	 */
+	protected function _renderConditionBinary(string $operator, string $sqlLeft, $sqlRight): string
+	{
+		return 'x';
+	}
+}
+
+class B extends A
+{
+	protected function _renderConditionBinary(string $operator, string $sqlLeft, $sqlRight): string
+	{
+		return 'y';
+	}
+}
+
+class C
+{
+	/**
+	 * @param string|($x is int ? float : bool) $y
+	 */
+	public function foo(mixed $x, mixed $y): void
+	{
+	}
+
+	/**
+	 * @return string|($x is int ? float : bool)
+	 */
+	public function bar(mixed $x): mixed
+	{
+		return '';
+	}
+}
+
+class D extends C
+{
+	/**
+	 * @param string|($x is int ? float : bool) $y
+	 */
+	public function foo(mixed $x, mixed $y): void
+	{
+	}
+
+	/**
+	 * @return string|($x is int ? float : bool)
+	 */
+	public function bar(mixed $x): mixed
+	{
+		return '';
+	}
+}