Report missing iterable value type for array part of array&callable intersections in MissingTypehintCheck

- In `MissingTypehintCheck::getIterableTypesWithMissingValueTypehint()`, the
  special-case block for `array&callable` intersection types was skipping the
  array part entirely, never checking it for missing value types
- Added a check for the array inner type's iterable value type before skipping
  it, so `callable-array`, `callable&array`, and `array&callable(...)` now
  correctly report `missingType.iterableValue` when the array has no value type
- Updated test expectations for `doIntersection()` (gains a third error for the
  outer array) and `doFoo()` (now reports missing iterable value type)
- Added new test case `doBaz()` with explicit `callable&array` parameter
- All consumers of `MissingTypehintCheck` (method/function parameters, return
  types, properties, constants, @var tags, @phpstan-assert) are automatically
  fixed since they share the same check

Author: VincentLanglet

src/Rules/MissingTypehintCheck.php

@@ -81,6 +81,10 @@ public function getIterableTypesWithMissingValueTypehint(Type $type): array
 				$nonArrayInner = [];
 				foreach ($type->getTypes() as $innerType) {
 					if ($innerType->isArray()->yes()) {
+						$iterableValue = $innerType->getIterableValueType();
+						if ($iterableValue instanceof MixedType && !$iterableValue->isExplicitMixed()) {
+							$iterablesWithMissingValueTypehint[] = $innerType;
+						}
 						continue;
 					}
 					$nonArrayInner[] = $innerType;

tests/PHPStan/Rules/Methods/MissingMethodParameterTypehintRuleTest.php

@@ -151,6 +151,11 @@ public function testBug7662(): void
 	public function testBug14549(): void
 	{
 		$this->analyse([__DIR__ . '/data/bug-14549.php'], [
+			[
+				'Method Bug14549\Foo::doFoo() has parameter $task with no value type specified in iterable type array.',
+				12,
+				MissingTypehintCheck::MISSING_ITERABLE_VALUE_TYPE_TIP,
+			],
 			[
 				'Method Bug14549\Foo::doFoo() has parameter $task with no signature specified for callable.',
 				12,
@@ -165,6 +170,20 @@ public function testBug14549(): void
 				46,
 				MissingTypehintCheck::MISSING_ITERABLE_VALUE_TYPE_TIP,
 			],
+			[
+				'Method Bug14549\Foo::doIntersection() has parameter $array with no value type specified in iterable type array.',
+				46,
+				MissingTypehintCheck::MISSING_ITERABLE_VALUE_TYPE_TIP,
+			],
+			[
+				'Method Bug14549\Foo::doBaz() has parameter $task with no value type specified in iterable type array.',
+				53,
+				MissingTypehintCheck::MISSING_ITERABLE_VALUE_TYPE_TIP,
+			],
+			[
+				'Method Bug14549\Foo::doBaz() has parameter $task with no signature specified for callable.',
+				53,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Methods/data/bug-14549.php

@@ -47,6 +47,13 @@ public function doIntersection($array): void
 	{
 	}
 
+	/**
+	 * @param callable&array $task
+	 */
+	public function doBaz(array $task): void
+	{
+	}
+
 }