Support named arguments for PDOStatement::fetchAll() overloaded parameters

PHP 8.4 accepts named arguments like `column:`, `class:`, and
`constructorArgs:` for PDOStatement::fetchAll() despite its native
signature using `mixed ...$args`. This commit:

1. Renames function map parameters to match PHP's actual named params
   (`mode`, `column`, `class`, `constructorArgs`, `callback`)

2. Updates Php8SignatureMapProvider to include function map parameters
   past the native variadic position in named argument variants, but
   only when all preceding param names align with native (preventing
   false positives for methods like PDO::query that don't support
   variadic-slot named params)

3. Enhances ParametersAcceptorSelector to perform name-based type
   matching when selecting among named argument variants, correctly
   rejecting variants whose required params don't match the call's
   named arguments

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

resources/functionMap.php

@@ -7833,10 +7833,10 @@
 'PDOStatement::errorInfo' => ['array'],
 'PDOStatement::execute' => ['bool', 'bound_input_params='=>'?array'],
 'PDOStatement::fetch' => ['mixed', 'how='=>'int', 'orientation='=>'int', 'offset='=>'int'],
-'PDOStatement::fetchAll' => ['array|false', 'how='=>'int'],
-'PDOStatement::fetchAll\'1' => ['array|false', 'fetch_column'=>'int', 'colno'=>'int'],
-'PDOStatement::fetchAll\'2' => ['array|false', 'fetch_class'=>'int', 'classname'=>'string', 'ctorargs='=>'?array'],
-'PDOStatement::fetchAll\'3' => ['array|false', 'fetch_func'=>'int', 'callback'=>'callable'],
+'PDOStatement::fetchAll' => ['array|false', 'mode='=>'int'],
+'PDOStatement::fetchAll\'1' => ['array|false', 'mode'=>'int', 'column'=>'int'],
+'PDOStatement::fetchAll\'2' => ['array|false', 'mode'=>'int', 'class'=>'string', 'constructorArgs='=>'?array'],
+'PDOStatement::fetchAll\'3' => ['array|false', 'mode'=>'int', 'callback'=>'callable'],
 'PDOStatement::fetchColumn' => ['string|null|false|int', 'column_number='=>'int'],
 'PDOStatement::fetchObject' => ['mixed', 'class_name='=>'string', 'ctor_args='=>'?array'],
 'PDOStatement::getAttribute' => ['mixed', 'attribute'=>'int'],

resources/functionMap_php80delta.php

@@ -97,10 +97,10 @@
 		'opcache_get_configuration' => ['array{directives: array{\'opcache.enable\': bool, \'opcache.enable_cli\': bool, \'opcache.use_cwd\': bool, \'opcache.validate_timestamps\': bool, \'opcache.validate_permission\': bool, \'opcache.validate_root\'?: bool, \'opcache.dups_fix\': bool, \'opcache.revalidate_path\': bool, \'opcache.log_verbosity_level\': int, \'opcache.memory_consumption\': int, \'opcache.interned_strings_buffer\': int, \'opcache.max_accelerated_files\': int, \'opcache.max_wasted_percentage\': float, \'opcache.consistency_checks\': int, \'opcache.force_restart_timeout\': int, \'opcache.revalidate_freq\': int, \'opcache.preferred_memory_model\': string, \'opcache.blacklist_filename\': string, \'opcache.max_file_size\': int, \'opcache.error_log\': string, \'opcache.protect_memory\': bool, \'opcache.save_comments\': bool, \'opcache.record_warnings\': bool, \'opcache.enable_file_override\': bool, \'opcache.optimization_level\': int, \'opcache.lockfile_path\'?: string, \'opcache.mmap_base\'?: string, \'opcache.file_cache\': string, \'opcache.file_cache_only\': bool, \'opcache.file_cache_consistency_checks\': bool, \'opcache.file_cache_fallback\'?: bool, \'opcache.file_update_protection\': int, \'opcache.opt_debug_level\': int, \'opcache.restrict_api\': string, \'opcache.huge_code_pages\'?: bool, \'opcache.preload\': string, \'opcache.preload_user\'?: string, \'opcache.cache_id\'?: string, \'opcache.jit\'?: string, \'opcache.jit_buffer_size\'?: int, \'opcache.jit_debug\'?: int, \'opcache.jit_bisect_limit\'?: int, \'opcache.jit_blacklist_root_trace\'?: int, \'opcache.jit_blacklist_side_trace\'?: int, \'opcache.jit_hot_func\'?: int, \'opcache.jit_hot_loop\'?: int, \'opcache.jit_hot_return\'?: int, \'opcache.jit_hot_side_exit\'?: int, \'opcache.jit_max_exit_counters\'?: int, \'opcache.jit_max_loop_unrolls\'?: int, \'opcache.jit_max_polymorphic_calls\'?: int, \'opcache.jit_max_recursive_calls\'?: int, \'opcache.jit_max_recursive_returns\'?: int, \'opcache.jit_max_root_traces\'?: int, \'opcache.jit_max_side_traces\'?: int, \'opcache.jit_prof_threshold\'?: int}, version: array{version: non-empty-string, opcache_product_name: non-empty-string}, blacklist: list<string>}|false'],
 		'parse_str' => ['void', 'encoded_string'=>'string', '&w_result'=>'array'],
 		'password_hash' => ['non-empty-string', 'password'=>'string', 'algo'=>'string|int|null', 'options='=>'array'],
-		'PDOStatement::fetchAll' => ['array', 'how='=>'int'],
-		'PDOStatement::fetchAll\'1' => ['array', 'fetch_column'=>'int', 'colno'=>'int'],
-		'PDOStatement::fetchAll\'2' => ['array', 'fetch_class'=>'int', 'classname'=>'string', 'ctorargs='=>'?array'],
-		'PDOStatement::fetchAll\'3' => ['array', 'fetch_func'=>'int', 'callback'=>'callable'],
+		'PDOStatement::fetchAll' => ['array', 'mode='=>'int'],
+		'PDOStatement::fetchAll\'1' => ['array', 'mode'=>'int', 'column'=>'int'],
+		'PDOStatement::fetchAll\'2' => ['array', 'mode'=>'int', 'class'=>'string', 'constructorArgs='=>'?array'],
+		'PDOStatement::fetchAll\'3' => ['array', 'mode'=>'int', 'callback'=>'callable'],
 		'PhpToken::tokenize' => ['list<PhpToken>', 'code'=>'string', 'flags='=>'int'],
 		'PhpToken::is' => ['bool', 'kind'=>'string|int|string[]|int[]'],
 		'PhpToken::isIgnorable' => ['bool'],

src/Reflection/ParametersAcceptorSelector.php

@@ -603,6 +603,7 @@ public static function selectFromTypes(
 		}
 
 		$typesCount = count($types);
+		$hasNamedTypes = count($types) > 0 && !array_is_list($types);
 		$acceptableAcceptors = [];
 
 		foreach ($parametersAcceptors as $parametersAcceptor) {
@@ -650,11 +651,18 @@ public static function selectFromTypes(
 			$acceptableAcceptor = GenericParametersAcceptorResolver::resolve($types, $acceptableAcceptor);
 			foreach ($acceptableAcceptor->getParameters() as $i => $parameter) {
 				if (!isset($types[$i])) {
-					if (!$unpack || count($types) <= 0) {
+					if ($hasNamedTypes && isset($types[$parameter->getName()])) {
+						$type = $types[$parameter->getName()];
+					} elseif ($hasNamedTypes && $parameter->isOptional()) {
+						continue;
+					} elseif ($hasNamedTypes) {
+						$isSuperType = TrinaryLogic::createNo();
+						break;
+					} elseif ($unpack && count($types) > 0) {
+						$type = $types[array_key_last($types)];
+					} else {
 						break;
 					}
-
-					$type = $types[array_key_last($types)];
 				} else {
 					$type = $types[$i];
 				}

src/Reflection/SignatureMap/Php8SignatureMapProvider.php

@@ -274,29 +274,45 @@ private function getMergedSignatures(FunctionSignature $nativeSignature, array $
 				$nativeParam = $nativeParams[$i] ?? null;
 				$allParamNamesMatchNative = $allParamNamesMatchNative && $nativeParam !== null && $functionParam->getName() === $nativeParam->getName();
 				$hasMiddleVariadicParam = $hasMiddleVariadicParam || $isPrevParamVariadic;
-				$isPrevParamVariadic = $functionParam->isVariadic() || (
-					$nativeParam !== null
-						? $nativeParam->isVariadic()
-						: false
-					);
+				$isPrevParamVariadic = $functionParam->isVariadic();
 			}
 
 			if ($hasMiddleVariadicParam) {
 				continue;
 			}
 
 			$parameters = [];
+			$allPrecedingNamesMatch = true;
 			foreach ($functionMapSignature->getParameters() as $i => $functionParam) {
 				if (!array_key_exists($i, $nativeParams)) {
 					continue 2;
 				}
 
-				// it seems that variadic parameters cannot be named in native functions/methods.
 				$nativeParam = $nativeParams[$i];
 				if ($nativeParam->isVariadic()) {
+					if ($allPrecedingNamesMatch) {
+						// Include remaining function map params with their own names.
+						// Some internal functions (e.g. PDOStatement::fetchAll) accept
+						// specific named parameters for their variadic slot when the
+						// function map aligns param names with native up to that point.
+						foreach (array_slice($functionMapSignature->getParameters(), $i) as $remainingParam) {
+							$parameters[] = new ParameterSignature(
+								$remainingParam->getName(),
+								$remainingParam->isOptional(),
+								$remainingParam->getType(),
+								$remainingParam->getNativeType(),
+								$remainingParam->passedByReference(),
+								$remainingParam->isVariadic(),
+								$remainingParam->getDefaultValue(),
+								$remainingParam->getOutType(),
+							);
+						}
+					}
 					break;
 				}
 
+				$allPrecedingNamesMatch = $allPrecedingNamesMatch && $functionParam->getName() === $nativeParam->getName();
+
 				$parameters[] = new ParameterSignature(
 					$nativeParam->getName(),
 					$functionParam->isOptional(),

tests/PHPStan/Rules/Methods/data/bug-5509.php

@@ -26,9 +26,14 @@ public function test(\PDOStatement $stmt): void
 		// With just mode - should not error
 		$stmt->fetchAll(\PDO::FETCH_ASSOC);
 
-		// Named arguments
+		// Named arguments - mode only
 		$stmt->fetchAll(mode: \PDO::FETCH_DEFAULT);
 		$stmt->fetchAll(mode: \PDO::FETCH_COLUMN);
 		$stmt->fetchAll(mode: \PDO::FETCH_CLASS);
+
+		// Named arguments - all parameters
+		$stmt->fetchAll(mode: \PDO::FETCH_COLUMN, column: 0);
+		$stmt->fetchAll(mode: \PDO::FETCH_CLASS, class: \stdClass::class);
+		$stmt->fetchAll(mode: \PDO::FETCH_CLASS, class: \stdClass::class, constructorArgs: [new \stdClass]);
 	}
 }