Do not carry forward any property fetch types into closure scope

Objects are always references in PHP, even when captured by value via
`use`. Properties (both dynamic and declared) can be modified between
closure definition and invocation, so their types should not be frozen
at closure definition time.

Simplify shouldNotCarryForwardPropertyFetchInClosure to skip all
PropertyFetch expressions, not just dynamic properties. Add test case
with declared property class (Foo with list<string> $items). Update
specified-types-closure-use.php expectations accordingly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

src/Analyser/MutatingScope.php

@@ -2224,24 +2224,7 @@ public function enterAnonymousFunctionWithoutReflection(
 
 	private function shouldNotCarryForwardPropertyFetchInClosure(Expr $expr): bool
 	{
-		if (!$expr instanceof PropertyFetch) {
-			return false;
-		}
-
-		if (!$expr->name instanceof Identifier) {
-			return false;
-		}
-
-		$objectType = $this->getType($expr->var);
-		$propertyName = $expr->name->name;
-
-		foreach ($objectType->getObjectClassReflections() as $classReflection) {
-			if ($classReflection->hasNativeProperty($propertyName)) {
-				return false;
-			}
-		}
-
-		return true;
+		return $expr instanceof PropertyFetch;
 	}
 
 	private function expressionTypeIsUnchangeable(ExpressionTypeHolder $typeHolder): bool

tests/PHPStan/Analyser/nsrt/specified-types-closure-use.php

@@ -13,7 +13,7 @@ public function doFoo(MethodCall $call, MethodCall $bar): void
 	{
 		if ($call->name instanceof Identifier && $bar->name instanceof Identifier) {
 			function () use ($call): void {
-				assertType('PhpParser\Node\Identifier', $call->name);
+				assertType('PhpParser\Node\Expr|PhpParser\Node\Identifier', $call->name);
 				assertType('mixed', $bar->name);
 			};
 
@@ -26,7 +26,7 @@ public function doBar(MethodCall $call, MethodCall $bar): void
 		if ($call->name instanceof Identifier && $bar->name instanceof Identifier) {
 			$a = 1;
 			function () use ($call, &$a): void {
-				assertType('PhpParser\Node\Identifier', $call->name);
+				assertType('PhpParser\Node\Expr|PhpParser\Node\Identifier', $call->name);
 				assertType('mixed', $bar->name);
 			};
 

tests/PHPStan/Rules/Arrays/data/bug-10345.php

@@ -13,3 +13,20 @@
 $container->items[] = '1';
 
 $a = $func();
+
+class Foo {
+	/** @var list<string> */
+	public array $items = [];
+}
+
+$container2 = new Foo();
+$container2->items = [];
+
+$func2 = function() use ($container2): int {
+	foreach ($container2->items as $item) {}
+	return 1;
+};
+
+$container2->items[] = '1';
+
+$a2 = $func2();