Merge sub-expression side effect checks into existing purity conditions

Instead of having a standalone subExpressionsHaveSideEffects check
separate from the existing MethodCall/StaticCall/FuncCall purity
conditions, merge the receiver chain and argument side effect checks
directly into those conditions. This addresses the review feedback
that the hasSideEffects() checking pattern was duplicated.

- MethodCall block: now also checks receiver ($expr->var) and args
- StaticCall block: now also checks class expr and args
- FuncCall blocks: now also check args for side effects
- Extract callLikeArgsHaveSideEffects() helper, reused by both
  the existing blocks and subExpressionsHaveSideEffects()
- subExpressionsHaveSideEffects() remains as catch-all for types
  not covered by the blocks above (PropertyFetch, ArrayDimFetch,
  NullsafeMethodCall, NullsafePropertyFetch, StaticPropertyFetch)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 2 people

src/Analyser/TypeSpecifier.php

@@ -2338,6 +2338,10 @@ private function createForExpr(
 			if (!$this->rememberPossiblyImpureFunctionValues && !$hasSideEffects->no()) {
 				return new SpecifiedTypes([], []);
 			}
+
+			if ($this->callLikeArgsHaveSideEffects($expr, $scope)) {
+				return new SpecifiedTypes([], []);
+			}
 		}
 
 		if (
@@ -2362,6 +2366,10 @@ private function createForExpr(
 					}
 				}
 			}
+
+			if ($this->callLikeArgsHaveSideEffects($expr, $scope)) {
+				return new SpecifiedTypes([], []);
+			}
 		}
 
 		if (
@@ -2375,6 +2383,8 @@ private function createForExpr(
 				$methodReflection === null
 				|| $methodReflection->hasSideEffects()->yes()
 				|| (!$this->rememberPossiblyImpureFunctionValues && !$methodReflection->hasSideEffects()->no())
+				|| $this->expressionHasSideEffects($expr->var, $scope)
+				|| $this->callLikeArgsHaveSideEffects($expr, $scope)
 			) {
 				if (isset($containsNull) && !$containsNull) {
 					return $this->createNullsafeTypes($originalExpr, $scope, $context, $type);
@@ -2400,6 +2410,8 @@ private function createForExpr(
 				$methodReflection === null
 				|| $methodReflection->hasSideEffects()->yes()
 				|| (!$this->rememberPossiblyImpureFunctionValues && !$methodReflection->hasSideEffects()->no())
+				|| ($expr->class instanceof Expr && $this->expressionHasSideEffects($expr->class, $scope))
+				|| $this->callLikeArgsHaveSideEffects($expr, $scope)
 			) {
 				if (isset($containsNull) && !$containsNull) {
 					return $this->createNullsafeTypes($originalExpr, $scope, $context, $type);
@@ -2466,11 +2478,22 @@ private function subExpressionsHaveSideEffects(Expr $expr, Scope $scope): bool
 			}
 		}
 
-		if ($expr instanceof Expr\CallLike && !$expr->isFirstClassCallable()) {
-			foreach ($expr->getArgs() as $arg) {
-				if ($this->expressionHasSideEffects($arg->value, $scope)) {
-					return true;
-				}
+		if ($expr instanceof Expr\CallLike && $this->callLikeArgsHaveSideEffects($expr, $scope)) {
+			return true;
+		}
+
+		return false;
+	}
+
+	private function callLikeArgsHaveSideEffects(Expr\CallLike $expr, Scope $scope): bool
+	{
+		if ($expr->isFirstClassCallable()) {
+			return false;
+		}
+
+		foreach ($expr->getArgs() as $arg) {
+			if ($this->expressionHasSideEffects($arg->value, $scope)) {
+				return true;
 			}
 		}