Also exclude nullsafe and static access from closure scope forwarding

Handle NullsafePropertyFetch, NullsafeMethodCall, StaticPropertyFetch,
and StaticCall in addition to PropertyFetch and MethodCall when entering
closure scope, since these can also be modified between closure definition
and invocation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 2 people

src/Analyser/MutatingScope.php

@@ -2080,7 +2080,14 @@ public function enterAnonymousFunctionWithoutReflection(
 				}
 			}
 
-			if ($expr instanceof PropertyFetch || $expr instanceof MethodCall) {
+			if (
+				$expr instanceof PropertyFetch
+				|| $expr instanceof MethodCall
+				|| $expr instanceof Expr\NullsafePropertyFetch
+				|| $expr instanceof Expr\NullsafeMethodCall
+				|| $expr instanceof Expr\StaticPropertyFetch
+				|| $expr instanceof Expr\StaticCall
+			) {
 				continue;
 			}
 

tests/PHPStan/Rules/Arrays/data/bug-10345.php

@@ -59,3 +59,58 @@ public function setItems(array $items): void
 
 	$a3 = $func3();
 }
+
+// Nullsafe property fetch
+$container4 = new Foo();
+$container4->items = [];
+
+$func4 = function() use ($container4): int {
+	foreach ($container4?->items as $item) {}
+	return 1;
+};
+
+$container4->items[] = '1';
+
+$a4 = $func4();
+
+// Static property access
+class Baz {
+	/** @var list<string> */
+	public static array $items = [];
+
+	/** @return list<string> */
+	public static function getItems(): array
+	{
+		return self::$items;
+	}
+
+	/** @param list<string> $items */
+	public static function setItems(array $items): void
+	{
+		self::$items = $items;
+	}
+}
+
+Baz::$items = [];
+
+$func5 = function(): int {
+	foreach (Baz::$items as $item) {}
+	return 1;
+};
+
+Baz::$items[] = '1';
+
+$a5 = $func5();
+
+// Static method call
+Baz::setItems([]);
+if (Baz::getItems() === []) {
+	$func6 = function(): int {
+		foreach (Baz::getItems() as $item) {}
+		return 1;
+	};
+
+	Baz::setItems(['foo']);
+
+	$a6 = $func6();
+}