cheap check first

staabm · staabm · commit 709fbd02a676 · 2026-03-04T07:35:48.000+01:00
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -4096,8 +4096,8 @@ private function createConditionalExpressions(
 
 			if (
 				array_key_exists($exprString, $newVariableTypes)
-				&& $newVariableTypes[$exprString]->equalTypes($holder)
 				&& !$newVariableTypes[$exprString]->getCertainty()->equals($holder->getCertainty())
+				&& $newVariableTypes[$exprString]->equalTypes($holder)
 			) {
 				continue;
 			}

Original file line number	Diff line number	Diff line change
`@@ -4096,8 +4096,8 @@ private function createConditionalExpressions(`
`4096`	`4096`
`4097`	`4097`	`if (`
`4098`	`4098`	`array_key_exists($exprString, $newVariableTypes)`
`4099`		`- && $newVariableTypes[$exprString]->equalTypes($holder)`
`4100`	`4099`	`&& !$newVariableTypes[$exprString]->getCertainty()->equals($holder->getCertainty())`
	`4100`	`+ && $newVariableTypes[$exprString]->equalTypes($holder)`
`4101`	`4101`	`) {`
`4102`	`4102`	`continue;`
`4103`	`4103`	`}`